Integrate oracles result handling #3850
Draft
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
Draft
Draft
piotmag769
reviewed
Oct 22, 2025
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs
Outdated
Show resolved
Hide resolved
commit-id:17bfed5d
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
20301a1 to
739b6a0
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
5be308b to
2fb1cab
Compare
Draft
piotmag769
reviewed
Oct 24, 2025
| StarknetApi(#[from] StarknetApiError), | ||
| #[error("Failed to parse {path} file")] | ||
| FileParsing { path: String }, | ||
| #[error("{error}")] |
There was a problem hiding this comment.
Is the conversion chain ByteArray -> String -> ByteArray a noop? It would be better to just have impl From<EnhancedHintError> for ByteArray at this point imo since this is what happens here
There was a problem hiding this comment.
It's noop, or at least it should be. I'll try what you've suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
RawFeltVec#3849