Skip to content

Integrate oracles result handling #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Parent: Refactor `RawFeltVec`
wants to merge 1 commit into
base: spr/master/30d7f8cd
Choose a base branch
from
Draft

Integrate oracles result handling #3850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ use cairo_vm::vm::{
};
use conversions::byte_array::ByteArray;
use conversions::felt::{ToShortString, TryInferFormat};
use conversions::serde::NoLengthFeltVec;
use conversions::serde::deserialize::BufferReader;
use conversions::serde::serialize::CairoSerialize;
use conversions::serde::serialize::{CairoSerialize, SerializeToFeltVec};
use data_transformer::cairo_types::CairoU256;
use rand::prelude::StdRng;
use runtime::{
Expand Down Expand Up @@ -97,7 +98,13 @@ impl<'a> ExtensionLogic for ForgeExtension<'a> {
let output = self
.oracle_hint_service
.execute_cheatcode(oracle_selector, input_reader.into_remaining());
return Ok(CheatcodeHandlingResult::Handled(output));
let mut reader = BufferReader::new(&output);
let deserialized: Result<NoLengthFeltVec<Felt>, ByteArray> = reader.read()?;
let converted = deserialized
.map_err(|error| EnhancedHintError::OracleError { error })
.map(|r| r.serialize_to_vec());

return Ok(CheatcodeHandlingResult::Handled(converted?));
}

match selector {
Expand Down
2 changes: 2 additions & 0 deletions crates/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ pub enum EnhancedHintError {
StarknetApi(#[from] StarknetApiError),
#[error("Failed to parse {path} file")]
FileParsing { path: String },
#[error("{error}")]
Copy link
Member

@piotmag769 piotmag769 Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the conversion chain ByteArray -> String -> ByteArray a noop? It would be better to just have impl From<EnhancedHintError> for ByteArray at this point imo since this is what happens here

Copy link
Member Author

@cptartur cptartur Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's noop, or at least it should be. I'll try what you've suggested

OracleError { error: ByteArray },
}

impl From<BufferReadError> for EnhancedHintError {
Expand Down
Loading