fix(shopify): validate missing shipping_lines in order payload#404
Open
ervishnucs wants to merge 2 commits intofrappe:developfrom
Open
fix(shopify): validate missing shipping_lines in order payload#404ervishnucs wants to merge 2 commits intofrappe:developfrom
ervishnucs wants to merge 2 commits intofrappe:developfrom
Conversation
ervishnucs
force-pushed
the
to_handle_pos_in_shopify
branch
from
b32dcc8 to
03190c7
Compare
ervishnucs
force-pushed
the
to_handle_pos_in_shopify
branch
from
03190c7 to
45fffd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Shopify POS orders may return payloads without shipping_lines (with shipping_lines = None), causing Sales Order creation to fail in ERPNext.
Ref:#58491