Skip to content

fix(shopify): validate missing shipping_lines in order payload #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ervishnucs wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(shopify): validate missing shipping_lines in order payload #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45fffd1
fix(shopify): validate missing shipping_lines in order payload
ervishnucs Feb 6, 2026
e4b6160
Merge branch 'develop' into to_handle_pos_in_shopify
ervishnucs Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 49 additions & 47 deletions ecommerce_integrations/shopify/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,61 +293,63 @@ def update_taxes_with_shipping_lines(taxes, shipping_lines, setting, items, taxe
"""Shipping lines represents the shipping details,
each such shipping detail consists of a list of tax_lines"""
shipping_as_item = cint(setting.add_shipping_as_item) and setting.shipping_item
for shipping_charge in shipping_lines:
if shipping_charge.get("price"):
shipping_discounts = shipping_charge.get("discount_allocations") or []
total_discount = sum(flt(discount.get("amount")) for discount in shipping_discounts)

shipping_taxes = shipping_charge.get("tax_lines") or []
total_tax = sum(flt(discount.get("price")) for discount in shipping_taxes)

shipping_charge_amount = flt(shipping_charge["price"]) - flt(total_discount)
if bool(taxes_inclusive):
shipping_charge_amount -= total_tax

if shipping_as_item:
items.append(
{
"item_code": setting.shipping_item,
"rate": shipping_charge_amount,
"delivery_date": items[-1]["delivery_date"] if items else nowdate(),
"qty": 1,
"stock_uom": "Nos",
"warehouse": setting.warehouse,
}
)
else:
if shipping_lines:
for shipping_charge in shipping_lines:
if shipping_charge.get("price"):
shipping_discounts = shipping_charge.get("discount_allocations") or []
total_discount = sum(flt(discount.get("amount")) for discount in shipping_discounts)

shipping_taxes = shipping_charge.get("tax_lines") or []
total_tax = sum(flt(discount.get("price")) for discount in shipping_taxes)

shipping_charge_amount = flt(shipping_charge["price"]) - flt(total_discount)
if bool(taxes_inclusive):
shipping_charge_amount -= total_tax

if shipping_as_item:
items.append(
{
"item_code": setting.shipping_item,
"rate": shipping_charge_amount,
"delivery_date": items[-1]["delivery_date"] if items else nowdate(),
"qty": 1,
"stock_uom": "Nos",
"warehouse": setting.warehouse,
}
)
else:
taxes.append(
{
"charge_type": "Actual",
"account_head": get_tax_account_head(shipping_charge, charge_type="shipping"),
"description": get_tax_account_description(shipping_charge)
or shipping_charge["title"],
"tax_amount": shipping_charge_amount,
"cost_center": setting.cost_center,
}
)

for tax in shipping_charge.get("tax_lines"):
taxes.append(
{
"charge_type": "Actual",
"account_head": get_tax_account_head(shipping_charge, charge_type="shipping"),
"description": get_tax_account_description(shipping_charge)
or shipping_charge["title"],
"tax_amount": shipping_charge_amount,
"account_head": get_tax_account_head(tax, charge_type="sales_tax"),
"description": (
get_tax_account_description(tax)
or f"{tax.get('title')} - {tax.get('rate') * 100.0:.2f}%"
),
"tax_amount": tax["price"],
"cost_center": setting.cost_center,
"item_wise_tax_detail": {
setting.shipping_item: [flt(tax.get("rate")) * 100, flt(tax.get("price"))]
}
if shipping_as_item
else {},
"dont_recompute_tax": 1,
}
)

for tax in shipping_charge.get("tax_lines"):
taxes.append(
{
"charge_type": "Actual",
"account_head": get_tax_account_head(tax, charge_type="sales_tax"),
"description": (
get_tax_account_description(tax)
or f"{tax.get('title')} - {tax.get('rate') * 100.0:.2f}%"
),
"tax_amount": tax["price"],
"cost_center": setting.cost_center,
"item_wise_tax_detail": {
setting.shipping_item: [flt(tax.get("rate")) * 100, flt(tax.get("price"))]
}
if shipping_as_item
else {},
"dont_recompute_tax": 1,
}
)


def get_sales_order(order_id):
"""Get ERPNext sales order using shopify order id."""
Expand Down