-
Notifications
You must be signed in to change notification settings - Fork 524
[WIP] .net core paket #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] .net core paket #2918
Conversation
85cff96 to
57fedd2
Compare
Yes FAKE is already on netcoreapp2.0 so upgrading Paket is OK for me. Thanks for taking care of this. |
|
nice, now time to rebase |
|
the merged nuspec is wrong ( <dependencies>
<group>
<dependency id="Chessie" version="0.6.0"></dependency>
<dependency id="FSharp.Compiler.Tools" version="0.0"></dependency>
<dependency id="FSharp.Core" version="0.0"></dependency>
<dependency id="Mono.Cecil" version="0.10.0-beta6"></dependency>
<dependency id="Newtonsoft.Json" version="0.0"></dependency>
</group>
<group targetFramework=".NETStandard2.0">
<dependency id="Mono.Cecil" version="0.10.0-beta6" exclude="Build,Analyzers"></dependency>
<dependency id="Chessie" version="0.6.0" exclude="Build,Analyzers"></dependency>
<dependency id="System.Security.Cryptography.ProtectedData" version="4.4.0" exclude="Build,Analyzers"></dependency>
<dependency id="Newtonsoft.Json" version="10.0.3" exclude="Build,Analyzers"></dependency>
</group>
</dependencies>the first one is the fallbackgroup, and is wrong. should be a also i see <dependency id="FSharp.Compiler.Tools" version="0.0"></dependency>
<dependency id="FSharp.Core" version="0.0"></dependency>that's not nice afaik. or not? |
|
Yes here: #2792 |
|
Ty @matthid , added my 👍 so is going to be resolved faster 😄 joking aside, fallback it;s just an issue if a |
|
only @forki appveyor seems to be fast enough, sigh. |
|
@forki @matthid what should i do about CI? now the build will take a bit longer (that's because we run "integration tests" for both .net and .net core version). For now in this PR i'll split the build in two matrix job.
pretty much like now as time used, twice as much worker used each commit (add up fast) but maybe leaving just @forki fast worker enabled, matth/cloudroutine disabled. no code changes and 1h build, can be a way too About travis, IF OK, i'll open a PR to disable failing test and open an issue about know failure. |
|
Maybe only testing netcore and getting travis green again is another option... |
|
@matthid @forki i prepared a repo ( https://github.com/enricosada/paket-netcore-testing this add both .net core, and pratically something really similar to repo level tool, because is tons easier to implement and works the same. i'll split that for the other PR. NOTE users project files doesnt need changes, is using the same bootstrapping is a bit tricky, but the idea is that boostrapper is:
|
|
meanwhile fixed on linux/mac (thx to @TheAngryByrd 👍 ). |
add netcore unit tests and integration tests
publish .net core fdd paket in `bin_netcore` directory
changes:
- ProjectFile.AssemblyName for new sdk projects, can be implicit
- paket init .net core doesnt download the boostrapper, not supported
- disable System.Configuration.ConfigurationManager based on NO_CONFIGURATIONMANAGER
- replace non working WebClient proxy under CUSTOM_WEBPROXY define
- ServicePointManager.SecurityProtocol exists in netstandard 2.0
- the WebRequest.DefaultWebProxy cannot be used on .net core
the IsBypassed throw "Operation is not supported on this platform."
for now, is disabled for .net standard, but need something to reenable it based on framework of runtime
add .net core fdd paket in tools/netcoreapp2.0
the paket.exe is duped in tools/net45
use env var: - PAKET_FEATURE_LOCALTOOL to use new localtool install - PAKET_FEATURE_NETCORE to use .net core paket bundle the target file in Paket nupkg shell script .paket/paket: - correct newline and dir separator - use mono in shell script for net - run chmod+x
|
splitted just .net core paket (and netstandard2.0 paket.core) in #2944 |
|
I think the only thing we need to verify here is that |
|
Closing.
|
have a
pakettargeting .net core app 2.0ref #2875
target just
netstandard2.0forPaket.Core(is ok @matthid ?), insteadof
netstandard1.6TODO:
fix the nuspec (is not right, there is a fallback group)