docs(#5598): add CLI-to-documentation cross-reference guide - #6375
Conversation
Contributors updating CLI command behavior had no way to discover all documentation locations for a given command group — PR fullsend-ai#5596 needed 5 review iterations for this reason. Add docs/contributing/documentation.md mapping the 7 major command groups to their doc touchpoints, plus a general grep-based discovery rule for minor commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Shai Revivo <srevivo@redhat.com>
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
PR Summary by QodoAdd CLI documentation cross-reference guide
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1.
|
Site previewPreview: https://6b21aa82-site.fullsend-ai.workers.dev Commit: |
|
/fs-review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🤖 Finished Review · ✅ Success · Started 10:08 AM UTC · Completed 10:23 AM UTC Commit: |
ReviewFindingsMedium
Low
|
…s, fix heading Add missing mint touchpoints (infrastructure-reference, advanced-setup, org-mode) and repos touchpoint (getting-inference). Rename heading from "Documentation Updates" to "Documentation" to match contributing doc conventions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Shai Revivo <srevivo@redhat.com>
waynesun09
left a comment
There was a problem hiding this comment.
Automated review sweep: 3 findings below.
…link tracking issue The original bullet said per-org mode is deprecated but didn't call out that the rule applies to human contributors as well as agents, or point anywhere for the specifics. waynesun09 noted on #6113 that the generic phrasing already failed to prevent recurrence on PR #6375, and scoped the fix here narrowly: state the deprecation status clearly and point to #2302 (which owns the command/code-path removal inventory) rather than duplicating that inventory in AGENTS.md. Apply the same clarification to the docs/agents/triage.md annotation so it reads consistently with AGENTS.md. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
The original bullet said per-org mode is deprecated but didn't call out that the rule applies to human contributors as well as agents, or point anywhere for the removal specifics. waynesun09 noted on #6113 that the generic phrasing already failed to prevent recurrence on PR #6375, so scope the fix narrowly: state the deprecation status clearly and point to ADR 0044's own implementation plan for which commands and code paths are in scope for removal, rather than duplicating that inventory in AGENTS.md. Drop the earlier reference to issue #2302 (closed as completed; its follow-up work was split into #6390-#6392, none of which tracks the removal as a whole) and the 'v2.0' target version, both of which are no longer accurate. Apply the same clarification to the docs/agents/triage.md annotation so it reads consistently with AGENTS.md. Signed-off-by: Wayne Sun <gsun@redhat.com> Assisted-by: Claude
The original bullet said per-org mode is deprecated but didn't call out that the rule applies to human contributors as well as agents, or point anywhere for the removal specifics. waynesun09 noted on #6113 that the generic phrasing already failed to prevent recurrence on PR #6375, so scope the fix narrowly: state the deprecation status clearly and point to #6391 (which enumerates the per-org-only CLI commands in scope for removal) rather than duplicating that inventory in AGENTS.md. Drop the earlier reference to issue #2302 (closed as completed; its follow-up work was split into #6390-#6392) and the 'v2.0' target version, neither of which is accurate: there's no v2.0 release gate, and the team decided against implementing #6391's original phased deprecation-warning scope in favor of removing per-org support directly (#6391 stays closed as not-planned, but its command enumeration remains the accurate reference). Apply the same clarification to the docs/agents/triage.md annotation so it reads consistently with AGENTS.md. Signed-off-by: Wayne Sun <gsun@redhat.com> Assisted-by: Claude
The original bullet said per-org mode is deprecated but didn't call out that the rule applies to human contributors as well as agents. waynesun09 noted on #6113 that the generic phrasing already failed to prevent recurrence on PR #6375, so make the instruction explicit: don't add or extend org-mode-specific content, and flag it as deprecated rather than active architecture when reviewing. Deliberately don't link a specific tracking issue for the command removal inventory: #2302 (originally linked) closed and split into #6390-#6392, and #6391 (the deprecation-warning issue that enumerated the commands) closed as not-planned when the team decided to remove per-org support directly instead of warning first. Issue state churns too fast for a rule file to track — the ADR link is stable and durable in a way a specific issue number is not, so point only to ADR 0044 and let it be the single source of truth for removal scope. Apply the same clarification to the docs/agents/triage.md annotation so it reads consistently with AGENTS.md. Signed-off-by: Wayne Sun <gsun@redhat.com> Assisted-by: Claude
- Fix ADR guidance to match docs/contributing/adrs.md (write a new superseding ADR, don't edit the original) - Scope admin section to admin foreign (active subcommand); note deprecated per-org tooling per ADR-0044 - Promote issues from minor-commands bucket to its own cross-reference section (has a dedicated user guide) - Add internal/cli/minttoken.go to mint Go source row - Expand grep discovery rule to include internal/cli/ for inline help Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Shai Revivo <srevivo@redhat.com>
waynesun09
left a comment
There was a problem hiding this comment.
Validated at head 0260ab29:
- All 49
docs//internal/paths referenced in the cross-reference exist on the PR head; both relative links (adrs.md, ADR 0044) resolve. - Command-group coverage matches the actual
root.goregistry — the 8 sections plus the minor-commands list account for all 16 registered root commands. - My round-2 findings are all fixed: ADR guidance now matches
adrs.md(supersede via new ADR, minor annotations only),adminis scoped to the supportedforeignpath with the ADR-0044 deprecation note,issueshas its own section pointing atissues-commands.md, and the heading/frontmatter/AGENTS.md link are consistent. - Bot findings addressed too: grep rule includes
internal/cli/, mint row gainedinfrastructure-reference.md/advanced-setup.md/org-mode.md+minttoken.go, repos gainedgetting-inference.md.
One residual nit, non-blocking: the admin foreign Go-source row lists only internal/cli/admin.go, but the foreign subcommand's implementation and Short/Long help text live in internal/cli/foreign.go (admin.go only registers it at line 74). Fine to fix in a follow-up; the general grep rule catches it. Qodo's remaining point about cli-internals.md missing post-comment flags concerns a pre-existing file and is out of this PR's scope.
Summary
docs/contributing/documentation.mdmapping 7 major CLI command groups (agent,admin,github,inference,mint,repos,run) to all their documentation touchpoints (CLI reference pages, user/dev guides, ADRs, Go source)grep-based discovery rule for minor commandsCloses #5598
Test plan
lycheelink checker not available locally — CI will run it)getMarkdownFiles())🤖 Generated with Claude Code