Skip to content

Support battery draining start via topics #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 15, 2021

🎉 New feature

Summary

Tracked vehicles were recently added and the implementation does not allow a battery to start draining. This PR is copied from @peci1 hot fix here: peci1/subt#2. Need by this SubT PR: osrf/subt#958

A test has been added and some documentation to the system's header file.

Test it

The new test should be self-explanatory.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested a review from azeey December 15, 2021 20:39
@nkoenig nkoenig requested a review from chapulina as a code owner December 15, 2021 20:39
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1255 (f88afb0) into ign-gazebo4 (c473a08) will increase coverage by 0.27%.
The diff coverage is 93.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1255      +/-   ##
===============================================
+ Coverage        66.41%   66.69%   +0.27%     
===============================================
  Files              250      250              
  Lines            19256    19270      +14     
===============================================
+ Hits             12789    12852      +63     
+ Misses            6467     6418      -49     
Impacted Files Coverage Δ
src/systems/battery_plugin/LinearBatteryPlugin.cc 63.01% <93.33%> (+21.98%) ⬆️
src/Server.cc 84.33% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c473a08...f88afb0. Read the comment docs.

@nkoenig nkoenig merged commit 772106d into ign-gazebo4 Dec 17, 2021
@nkoenig nkoenig deleted the battery_topics branch December 17, 2021 16:42
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants