Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict docker-nightly workflow to base branch #2827

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes extra triggering of nightly workflow

Summary

Currently the nightly workflow is triggered for any branch that receives a push, but we just want it to run on the base branch, so restrict it to gz-sim9.

When merging forward to main, I expect to change this to main.

Note that I originally noticed this when it ran and failed during #2826.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Currently the nightly workflow is triggered for any
branch that receives a push, but we just want it
to run on the base branch.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mjcarroll as a code owner March 17, 2025 22:53
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Mar 17, 2025
@scpeters scpeters requested a review from iche033 March 17, 2025 22:54
@scpeters scpeters merged commit d9024d8 into gz-sim9 Mar 18, 2025
11 of 12 checks passed
@scpeters scpeters deleted the scpeters/nightly_base_branch branch March 18, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants