Issue2806

[GauravKumar9920]

🦟 Bug fix and New feature

Fixes #2806

Summary

Previously, when launching multiple GZ Sim servers, for instance, using the commands gz sim -s shapes.sdf and gz sim -s default.sdf,

If we had used the command gz sim -g ‘fileName’,
It would not have considered the fileName parameter and would have launched any of the servers at random.

This pr introduces a new feature that allows you to -

• Launch a file by passing the file name as an argument. For instance, you can utilize the command gz sim -g ‘fileName’ to launch the GUI, provided that the server(s) are operational.
• Warn the user if there are multiple servers running in case where we don't pass the fileName as an argument. eg - gz sim -g. In case there's just one server running it will simply launch the gui of the same.

[arjo129]

This diff is absolutely massive for such a small change. I've left some architectural feedback here: #2806 (comment)

Also when committing please sign off with git commit -s.

I think we can break these down into small PRs.

[iche033]

I think the big diff is also partly due to indentation changes, e.g. https://github.com/gazebosim/gz-sim/pull/2828/files?w=1 shows diff without whitespace changes. Can you undo indentation changes?

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (1509b0f) to head (b29df6a).
Report is 5 commits behind head on gz-sim9.

Files with missing lines	Patch %	Lines
src/SimulationRunner.cc	66.66%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           gz-sim9    #2828      +/-   ##
===========================================
- Coverage    68.95%   68.94%   -0.01%     
===========================================
  Files          345      345              
  Lines        33332    33354      +22     
===========================================
+ Hits         22983    22997      +14     
- Misses       10349    10357       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arjo129]

This is looking a lot better. Most of my comments are more to do with syntax and style. I have one tiny knit regarding returning an incompletely constructed object. For now we should just continue with construction as is. In Jetty we can consider throwing an error.

[arjo129]

LGTM! Thanks for iterating.