Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QML warnings from Inertial.qml in Component Inspector #2830

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 21, 2025

🦟 Bug fix

Summary

Fixes a flood of warnings when clicking on a link of a model in the Entity Tree GUI plugin:

(2025-03-21 18:23:44.927) [warning] [Application.cc:915] [GUI] [QT] file::/ComponentInspector/Inertial.qml:343:13: Unable to assign [undefined] to QString
(2025-03-21 18:23:44.927) [warning] [Application.cc:915] [GUI] [QT] file::/ComponentInspector/Inertial.qml:351:13: Unable to assign [undefined] to QString
(2025-03-21 18:23:44.927) [warning] [Application.cc:915] [GUI] [QT] file::/ComponentInspector/Inertial.qml:359:13: Unable to assign [undefined] to QString
...

This is because these extra inertial data only exist if the link has fluid added mass specified

To test:

  1. launch shapes.sdf world,
  2. Go the the Entity Tree GUI plugin on the right and expand the box model
  3. Click on link-> you should no longer see these warnings above

You can also verify that the component inspector's inertial component still works for a link with added mass

  1. launch fluid_added_mass.sdf wrold
  2. Go the the Entity Tree GUI plugin on the right and expand the box_xx_xy_xz model
  3. Click on link-> no warnings should be printed
  4. Go to the Component Inspector GUI plugin above the Entity Tree, expand Inertial entry to see the Fluid added mass values.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 21, 2025 19:03
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

1 participant