Conversation
Add the Material dependency and update the app theme to Material3 DayNight. build.gradle.kts now includes implementation(libs.material) and Theme.Wallet parent changed from android:Theme.Material.Light.NoActionBar to Theme.Material3.DayNight.NoActionBar to enable Material3 components and day/night theming.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements style adjustments to enhance the application's visual presentation. It addresses proper edge-to-edge display integration by correcting the order of an initialization call and modernizes the app's look and feel by upgrading its theme to Material 3. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix edge-to-edge styling. While updating the theme in themes.xml to Material 3 is a good step, the change in MainActivity.kt is incorrect. The call to enableEdgeToEdge() has been moved after super.onCreate(), which contradicts the official Android documentation and can break the intended functionality. I've left a critical comment with a suggestion to revert this specific change.
| super.onCreate(savedInstanceState) | ||
| enableEdgeToEdge() |
There was a problem hiding this comment.
The call to enableEdgeToEdge() should be placed before super.onCreate(savedInstanceState). According to the official Android documentation, enableEdgeToEdge() must be called before super.onCreate() to correctly configure the activity for edge-to-edge display. Moving it after super.onCreate() can lead to incorrect layout behavior and visual glitches.
| super.onCreate(savedInstanceState) | |
| enableEdgeToEdge() | |
| enableEdgeToEdge() | |
| super.onCreate(savedInstanceState) |
No description provided.