Skip to content

Style fix: edge-to-edge #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
furenster merged 2 commits into from
Mar 3, 2026
Merged

Style fix: edge-to-edge #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ddbcd1
Add Material lib and migrate to Material3 theme
gemcoder21 Mar 3, 2026
f7d2649
Clean code
furenster Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/kotlin/com/gemwallet/android/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ class MainActivity : FragmentActivity(), AuthRequester {
private var onSuccessAuth: (() -> Unit)? = null

override fun onCreate(savedInstanceState: Bundle?) {
enableEdgeToEdge()
super.onCreate(savedInstanceState)
enableEdgeToEdge()
Comment on lines 84 to +85
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The call to enableEdgeToEdge() should be placed before super.onCreate(savedInstanceState). According to the official Android documentation, enableEdgeToEdge() must be called before super.onCreate() to correctly configure the activity for edge-to-edge display. Moving it after super.onCreate() can lead to incorrect layout behavior and visual glitches.

Suggested change
super.onCreate(savedInstanceState)
enableEdgeToEdge()
enableEdgeToEdge()
super.onCreate(savedInstanceState)

prepareBiometricAuth()

viewModel.handleIntent(this@MainActivity.intent)
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/themes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>

<style name="Theme.Wallet" parent="android:Theme.Material.Light.NoActionBar" />
<style name="Theme.Wallet" parent="Theme.Material3.DayNight.NoActionBar" />
</resources>
Loading