Repository navigation
ref(sourcemaps): Read has_debug_ids in the source map debugger - #130425
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
lcian
previously approved these changes
Nov 9, 2026
sentry-junior
Bot
force-pushed
the
ref/source-map-debug-read-has-debug-ids
branch
from
November 9, 2026 16:06
d99b69d to
6b28c6c
Compare
Contributor
Sentry Snapshot Testing
|
sentry-junior
Bot
force-pushed
the
ref/source-map-debug-read-has-debug-ids
branch
from
November 9, 2026 16:37
6b28c6c to
6affdfd
Compare
mchen-sentry
added
the
Trigger: getsentry tests
sentry-junior
Bot
force-pushed
the
ref/source-map-debug-read-has-debug-ids
branch
from
November 10, 2026 15:32
5bee948 to
2430a48
Compare
sentry-junior
Bot
dismissed
lcian’s stale review
November 10, 2026 15:34
The stack changed: has_debug_ids moved from ArtifactBundle to ProjectArtifactBundle with a partial index on project_id, and the PRs are rebased on master. Please review again.
lcian
approved these changes
Nov 10, 2026
When none of an event's debug IDs matched, project_has_some_artifact_with_a_debug_id now checks the has_debug_ids flag on the project's ProjectArtifactBundle links. The partial index answers this with one lookup, whether or not the project has such a link, so the check no longer reads DebugIdArtifactBundle and no longer needs the debug-id-check-max-bundles cap. The option stays registered until the automator stops setting it. Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com> Co-Authored-By: Lorenzo Cian <lorenzo.cian@sentry.io>
sentry-junior
Bot
force-pushed
the
ref/source-map-debug-read-has-debug-ids
branch
from
November 11, 2026 23:13
2430a48 to
e66f49e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source map debugger checks if a project uploaded any file with a debug ID. This check now queries
ProjectArtifactBundlefor a link of the project withhas_debug_ids = true. It does not read the debug-ID rows of the organization anymore.The partial index from #130424 answers this query with one index lookup. This is true when the project has such a link and when it does not. A local check on a synthetic table with 2M rows gave an index-only scan on the partial index that read 4 to 6 buffers in both cases.
The query is now bounded, so this PR removes the
debug-id-check-max-bundlescap and its code path. The cap also gave a wrong result for projects whose debug IDs were only in older bundles. The option stays registered for now. First remove its value from the options automator. Then remove the registration in a follow-up PR.The lookup of the debug IDs of the event still uses the debug-ID table, because it needs the file type of each debug ID.
Merge this PR only after both post-deployment migrations from #130424 ran in all regions. Without the index, this query reads all links of the project.
Requires #130424
via @jan-auer.
--
View Session [Sentry]