Skip to content

fix(nav): Keep section title and chevron on one row in settings nav - #130889

Merged
priscilawebdev merged 1 commit into
masterfrom
priscilawebdev/fix/settings-nav-section-header
Nov 12, 2026
Merged

priscilawebdev merged 1 commit into
masterfrom
priscilawebdev/fix/settings-nav-section-header

Conversation

@priscilawebdev

@priscilawebdev priscilawebdev commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Before

image

After

image

The legacy secondary nav section header put a two-column Grid onto a
transparent Button. Since #130883, transparent button labels inherit the
button's display, but not its grid columns, so the label became a
single-column grid and the chevron stacked under the title.

Use a Flex instead, which the label inherits correctly.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 12, 2026
@priscilawebdev
priscilawebdev marked this pull request as ready for review November 12, 2026 10:05
@priscilawebdev
priscilawebdev requested a review from a team as a code owner November 12, 2026 10:05
@priscilawebdev
priscilawebdev enabled auto-merge (squash) November 12, 2026 10:05

@Angelodaniel Angelodaniel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@priscilawebdev
priscilawebdev merged commit 472ff40 into master Nov 12, 2026
80 checks passed
@priscilawebdev
priscilawebdev deleted the priscilawebdev/fix/settings-nav-section-header branch November 12, 2026 10:11
priscilawebdev added a commit that referenced this pull request Nov 12, 2026
Adds visual snapshots for the secondary navigation so layout regressions
like the one fixed in #130889 (collapsible section title and chevron
stacking onto two rows in the settings nav) get caught in CI.

This branch was successfully deployed

1 active deployment
Preview — 99809a8d Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants