-
Notifications
You must be signed in to change notification settings - Fork 687
feat(control-plane): [issue-4833] AWS SSM Parameter store tags #4834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for tagging AWS SSM Parameter Store parameters by adding a new parameter_store_tags variable that allows users to specify custom tags to be applied to all SSM parameters created by the Lambda functions.
- Adds a new
parameter_store_tagsvariable across all modules to accept user-defined tags - Updates Lambda functions to read and apply these tags when creating SSM parameters
- Transforms the tag map into the required format for AWS SSM API calls
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variables.tf | Adds new parameter_store_tags variable definition at root level |
| modules/runners/variables.tf | Adds parameter_store_tags variable to runners module |
| modules/runners/local.tf | Creates local transformation to convert tag map to AWS format |
| modules/runners/scale-up.tf | Passes transformed tags to scale-up Lambda environment |
| modules/runners/pool/ | Updates pool module to handle parameter store tags |
| modules/multi-runner/ | Adds parameter store tags support to multi-runner module |
| main.tf | Passes parameter store tags variable to runners module |
| lambdas/ | Updates Lambda functions to parse and apply tags to SSM parameters |
| README.md files | Updates documentation to include new parameter store tags variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| timeout = number | ||
| zip = string | ||
| subnet_ids = list(string) | ||
| parameter_store_tags = string |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type for parameter_store_tags should be map(string) to match the variable definition in other modules, not string.
| parameter_store_tags = string | |
| parameter_store_tags = map(string) |
| : []; | ||
| const ssmParameterStoreTags = process.env.SSM_PARAMETER_STORE_TAGS | ||
| ? JSON.parse(process.env.SSM_PARAMETER_STORE_TAGS) | ||
| : {}; |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value should be an empty array [] instead of an empty object {} to match the expected type structure used in the scale-up function and maintain consistency.
| : {}; | |
| : []; |
| disableAutoUpdate: boolean; | ||
| ssmTokenPath: string; | ||
| ssmConfigPath: string; | ||
| ssmParameterStoreTags: { Key: string; Value: string }[]; |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The interface property should use consistent naming. Consider renaming to ssmParameterStoreTags to match the environment variable name pattern or use a more descriptive name like parameterStoreTags.
| ssmParameterStoreTags: { Key: string; Value: string }[]; | |
| parameterStoreTags: { Key: string; Value: string }[]; |
|
@wadherv thx for your PR, I wont have no option to check open PRs till the end of the month, sorry for the delay |
Introducing a new variable
parameter_store_tagsto add tags for all the SSM Parameter Store resources created via Scale-Up and Pool lambda function.