Skip to content

Conversation

@jonjanego
Copy link
Member

adding quality-related tags per metadata styleguide

adding quality tags per metadata styleguide
@jonjanego jonjanego marked this pull request as ready for review April 1, 2025 23:49
Copilot AI review requested due to automatic review settings April 1, 2025 23:49
@jonjanego jonjanego requested a review from a team as a code owner April 1, 2025 23:49
@github-actions github-actions bot added the JS label Apr 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • javascript/ql/src/Expressions/ExprHasNoEffect.ql: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Apr 2, 2025
@erik-krogh
Copy link
Contributor

You need to autoformat the file.
E.g. codeql query format -i <path-to-file>.

Otherwise looks good 👍

@jonjanego
Copy link
Member Author

You need to autoformat the file. E.g. codeql query format -i <path-to-file>.

Otherwise looks good 👍

oh I can't just update this file directly? i just made a direct edit.

@jonjanego jonjanego requested a review from Napalys April 2, 2025 16:40
@jonjanego jonjanego merged commit d513012 into main Apr 2, 2025
13 checks passed
@jonjanego jonjanego deleted the jonjanego/useless-expression-tags branch April 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JS no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants