Skip to content

Rust: Add type inference test cases for tuples. #20004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jul 9, 2025

Add type inference test cases for tuples. We worked around this in https://github.com/github/codeql/pull/19946/files#r2192987950 . @hvitved FYI.

@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 16:03
@geoffw0 geoffw0 requested a review from a team as a code owner July 9, 2025 16:03
@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code labels Jul 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

hvitved
hvitved previously approved these changes Jul 9, 2025
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking: Did you run rustfmt --edition 2024 main.rs?

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jul 9, 2025

Just done.

hvitved
hvitved previously approved these changes Jul 9, 2025
@aibaars
Copy link
Contributor

aibaars commented Jul 10, 2025

FYI: I also created a similar PR #20003 . Currently type inference does not work for pattern matches (including tuples).

@geoffw0 geoffw0 merged commit ae3253b into github:main Jul 10, 2025
15 checks passed
@geoffw0
Copy link
Contributor Author

geoffw0 commented Jul 10, 2025

FYI: I also created a similar PR #20003 .

Seems like they're different enough we should have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants