Skip to content

fix(instructions-janitor): use GitHub MCP get_latest_release instead of git describe #23625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 31, 2026
+30 −28
Merged

fix(instructions-janitor): use GitHub MCP get_latest_release instead of git describe #23625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa4356
Initial plan
Copilot Mar 31, 2026
3418595
Initial plan
Copilot Mar 31, 2026
454d68d
fix(instructions-janitor): use GitHub MCP get_latest_release instead …
Copilot Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/daily-doc-updater.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 18 additions & 19 deletions .github/workflows/instructions-janitor.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions .github/workflows/instructions-janitor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ tools:
- "cat .github/aw/github-agentic-workflows.md"
- "wc -l .github/aw/github-agentic-workflows.md"
- "git log --since='*' --pretty=format:'%h %s' -- docs/"
- "git describe --tags --abbrev=0"

timeout-minutes: 15

Expand All @@ -55,13 +54,13 @@ Analyze documentation changes since the latest release and ensure the instructio

### 1. Identify Latest Release

Determine the latest release version to establish a baseline:
Determine the latest release version and its publish date:

```bash
git describe --tags --abbrev=0
```
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code fence for the get_latest_release(...) call is missing a language tag (e.g., text). This file’s own style guidelines (see “Use YAML/markdown code blocks with appropriate language tags”) and other workflow instruction files use language tags, so this block should be updated for consistency/readability.

Suggested change
```
```text

Copilot uses AI. Check for mistakes.
get_latest_release(owner="github", repo="gh-aw")
```

If no tags exist, use the date from the CHANGELOG.md file to find the latest release version.
Use the `tag_name` field as the release version and the `published_at` field as `RELEASE_DATE`.

Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous instructions included a fallback for repos without tags; after switching to get_latest_release, there’s no equivalent guidance for the case where the repo has no releases / the API returns 404. Without a fallback, the workflow run may get stuck without a RELEASE_DATE baseline. Consider documenting a deterministic fallback (e.g., use the most recent tag via list_tags, or use the latest CHANGELOG entry date) when get_latest_release returns no result.

Suggested change
If `get_latest_release` returns no result (for example, the repository has no releases and the API returns 404), fall back to a deterministic baseline:
- Use the GitHub toolset to list tags and select the most recent tag:
- `list_tags(owner="github", repo="gh-aw")` (or equivalent).
- Use the latest tag’s `name` as the release version.
- Set `RELEASE_DATE` to the commit date of that tag (for example, via `git log -1 --format="%aI" TAG_NAME` or the corresponding commit date from the GitHub API).

Copilot uses AI. Check for mistakes.
### 2. Analyze Documentation Changes

Expand All @@ -72,6 +71,8 @@ Review documentation changes since the latest release:
git log --since="RELEASE_DATE" --pretty=format:"%h %s" -- docs/
```

where `RELEASE_DATE` is the `published_at` date from the release API response.

For each commit affecting documentation:
- Use `get_commit` to see detailed changes
- Use `get_file_contents` to review modified documentation files
Expand Down
Loading