Skip to content

docs: remove deprecated --skip-tls references from local-development guide#2231

Merged
mnriem merged 3 commits intogithub:mainfrom
ayesha-aziz123:docs/remove-skip-tls-references
Apr 15, 2026
Merged

docs: remove deprecated --skip-tls references from local-development guide#2231
mnriem merged 3 commits intogithub:mainfrom
ayesha-aziz123:docs/remove-skip-tls-references

Conversation

@ayesha-aziz123
Copy link
Copy Markdown
Contributor

Summary

The --skip-tls flag is deprecated and no longer has any effect on
specify init or specify check. However, docs/local-development.md
still documents it as a working option in two places:

  • Section 9 shows example commands using --skip-tls
  • Section 12 (Common Issues table) recommends --skip-tls for TLS errors

This PR removes the outdated references and replaces them with accurate guidance.

Changes

  • docs/local-development.md: Updated Section 9 and Section 12 table

Verification

Running specify init --help confirms --skip-tls is not listed as an option.

AI Disclosure

I used Claude Code to help identify this issue by analyzing the repository files.
The fix was manually verified and applied by me.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes outdated documentation for the deprecated --skip-tls flag in the local development guide so troubleshooting advice matches current CLI behavior.

Changes:

  • Replaced --skip-tls example commands with a deprecation note and alternative guidance.
  • Updated the “Common Issues” table entry for corporate-network TLS errors to remove the deprecated recommendation.
Show a summary per file
File Description
docs/local-development.md Removes --skip-tls usage references and updates TLS troubleshooting guidance to reflect deprecation.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

Comment thread docs/local-development.md Outdated
@@ -130,14 +130,10 @@ Or copy only the modified CLI portion if you want a lighter sandbox.

## 9. Debug Network / TLS Skips
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section title still says "TLS Skips" even though the --skip-tls option is now described as deprecated/ineffective. Consider renaming the heading to avoid implying TLS bypass behavior (e.g., "Debug Network / TLS" or similar).

Suggested change
## 9. Debug Network / TLS Skips
## 9. Debug Network / TLS

Copilot uses AI. Check for mistakes.
Comment thread docs/local-development.md
```

(Use only for local experimentation.)

Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two consecutive blank lines before the next section header, which is inconsistent with the surrounding formatting. Remove one of the blank lines to keep spacing consistent.

Suggested change

Copilot uses AI. Check for mistakes.
Comment thread docs/local-development.md Outdated
Comment on lines +133 to +135
> **Note:** The `--skip-tls` flag is deprecated and no longer has any effect.
> If you encounter TLS errors on a corporate network, configure your
> environment's certificate store or proxy instead.
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance "configure your environment's certificate store or proxy" is accurate but a bit non-actionable for a local-dev troubleshooting section. Consider adding 1–2 concrete examples (e.g., typical proxy env vars like HTTP(S)_PROXY and/or CA bundle env vars like SSL_CERT_FILE / REQUESTS_CA_BUNDLE) so readers know what to try next.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback. If not applicable, please explain why

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local development guide to remove outdated documentation for the deprecated --skip-tls flag and replace it with guidance that reflects the CLI’s current behavior.

Changes:

  • Replaced the “TLS skip” example commands with a deprecation note and recommended troubleshooting direction.
  • Updated the Common Issues table entry for corporate-network TLS errors to remove the --skip-tls suggestion.
Show a summary per file
File Description
docs/local-development.md Removes deprecated --skip-tls usage examples and updates TLS troubleshooting guidance to reflect the flag being a no-op.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

docs/local-development.md:165

  • The Common Issues table entry repeats the longer guidance from Section 9, which can drift over time. Consider keeping the table cell short and pointing to Section 9 for the full TLS/corporate network troubleshooting steps (while still noting that --skip-tls is deprecated).
| TLS errors on corporate network | Configure your environment's certificate store or proxy. The `--skip-tls` flag is deprecated and has no effect. |
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new

@mnriem mnriem requested a review from Copilot April 15, 2026 20:09
@ayesha-aziz123
Copy link
Copy Markdown
Contributor Author

Thanks for the review! I've addressed the feedback:

  • Clarified the deprecation note for --skip-tls
  • Removed ambiguity around "skips"
  • Improved wording to keep the tone consistent with the rest of the guide

Please let me know if anything else should be adjusted.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes outdated documentation for the deprecated --skip-tls CLI flag in the local development guide, replacing it with guidance that reflects the current behavior (flag is a no-op) and points developers toward proper TLS/proxy configuration.

Changes:

  • Renamed Section 9 to focus on TLS issues (instead of “TLS skips”) and replaced the old --skip-tls examples with deprecation + environment configuration guidance.
  • Updated the “Common Issues” table to stop recommending --skip-tls for corporate-network TLS failures.
Show a summary per file
File Description
docs/local-development.md Removes deprecated --skip-tls references and replaces them with current TLS troubleshooting guidance.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new

@mnriem mnriem self-requested a review April 15, 2026 20:15
@mnriem mnriem merged commit 27b4fd2 into github:main Apr 15, 2026
12 checks passed
@mnriem
Copy link
Copy Markdown
Collaborator

mnriem commented Apr 15, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants