Use rich type columns and endpoint kinds for Python model editor #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
I've tried running this and it worked fine for me, but it's the first time I've used the model editor for python so I'm not very confident I tested it thoroughly.
Looking through the code I can't see anything wrong, but there's a lot going on so it's hard to tell.
LGTM, unless you want to get someone from the python team to also try it out
koesie10
deleted the
koesie10/python-use-simplified-paths-and-endpoint-kinds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes changes to the Python model editor parsing code to incorporate the query changes from github/codeql#15655. These changes consist of:
typecolumn in MaD codeql#16490): This makes it possible to replace the columns["requests", "Member[adapters].Member[HTTPAdapter].Instance.Member[add_headers]"]by["requests.HTTPAdapter", "Member[add_headers]"].kindcolumn that has been added in Python: Support model editor codeql#15655 (the last column returned in the query). This makes it possible to properly handle class methods, which we would otherwise need to detect by the name of the method argument rather than just receiving this information from the query.For more information about the format of Python MaD, see the documentation.