Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 17, 2025

Description

  • Adds search by URL for GitLab Self Managed to the Launchpad
  • Adds search by URL for GitHub Enterprise to the Launchpad

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 0d463ae to 261dc44 Compare January 17, 2025 02:33
@sergeibbb
Copy link
Member Author

sergeibbb commented Jan 17, 2025

@axosoft-ramint

Now it doesn't harm users. Just search by URL doesn't work for self hosted GitHub and GitLab. That is why I suppose this PR can be merged after the release as a follow-up.

I haven't changed the CHANGELOG yet, because if we decide to merge before the release, it will be covered by general notes of adding self-hosted GitLab and GitHub.

Also, I've noticed that GitLab's and GitHub's methods are similar: they get a value without provider field and then extend it with this.id. I wanted to move it to the base class, but the return type is incompatible with Jira.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant