Skip to content
This repository was archived by the owner on Oct 18, 2025. It is now read-only.

Add more fakes#66

Merged
qwandor merged 5 commits into
mainfrom
fakes
Jul 17, 2025
Merged

Add more fakes#66
qwandor merged 5 commits into
mainfrom
fakes

Conversation

@qwandor

@qwandor qwandor commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@imre-kis-arm

Copy link
Copy Markdown

This PR looks good to me, it works fine with arm-fvp-base-pac and rust-spmc too.
My only concern is the default target in .cargo/config.toml.
Running cargo test now requires explicitly specifying the --target [host target] parameter, which ties the command to a specific architecture. This makes it difficult to write test or CI scripts that are architecture-independent.
In contrast, for cargo build we always know that the target is aarch64-* or arm-* regardless of the host architecture, so hard coding the target is acceptable.
Ideally, we could select whether this configuration value applies to cargo test, but currently, there doesn't seem to be a way to do that.

qwandor added 2 commits July 17, 2025 15:54
This requires CI to choose an explicit target matching the host, which
we don't want.
@qwandor

qwandor commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

Fair point. I've removed the .cargo/config.toml now.

@imre-kis-arm

Copy link
Copy Markdown

LGTM, thanks.

@qwandor qwandor merged commit 811a333 into main Jul 17, 2025
6 checks passed
@qwandor qwandor deleted the fakes branch July 17, 2025 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants