Skip to content

Conversation

Not-Dhananjay-Mishra
Copy link

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra commented Aug 18, 2025

This PR adds support for two new Secret Scanning API endpoints that are currently missing from the go-github library

Implement

POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypasses
GET /repos/{owner}/{repo}/secret-scanning/scan-history

Changes

  • Add CreatePushProtectionBypass method
  • Add GetScanHistory method
  • Made two new struct for PushProtectionBypasses method - PushProtectionBypassRequest and PushProtectionBypass
  • Made three new struct for ScanHistory method - Scan, CustomPatternScan and SecretScanningResponse

Issue - #3686

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.10%. Comparing base (3a062d1) to head (c7213dc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3687      +/-   ##
==========================================
+ Coverage   91.08%   91.10%   +0.01%     
==========================================
  Files         187      187              
  Lines       16581    16607      +26     
==========================================
+ Hits        15103    15129      +26     
  Misses       1293     1293              
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Not-Dhananjay-Mishra
Copy link
Author

@alexandear Thanks for the suggestions. I have changed the method names. Please let me know if you have any other suggestions.

Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Not-Dhananjay-Mishra.
This is a good start. Please address the findings and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 18, 2025
@Not-Dhananjay-Mishra
Copy link
Author

Thanks @gmlewis for the feedback! I have fixed all the findings. Sorry for the extra back and forth code review.

Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

if err != nil {
return nil, nil, err
}
var reponsePushProtectionBypass *PushProtectionBypass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var reponsePushProtectionBypass *PushProtectionBypass
var responsePushProtectionBypass *PushProtectionBypass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexandear for spotting that! That was an accidental typo. I've fixed it.

@gmlewis
Copy link
Contributor

gmlewis commented Aug 18, 2025

Just FYI - suddenly I have lost write access to this repo, like in #3689... so I can no longer approve the workflows and need to find out what is going on... this may take some time to resolve... I apologize for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsReview PR is awaiting a review before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants