-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add GitHub two new Secret Scanning API endpoints #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add GitHub two new Secret Scanning API endpoints #3687
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
+ Coverage 91.08% 91.10% +0.01%
==========================================
Files 187 187
Lines 16581 16607 +26
==========================================
+ Hits 15103 15129 +26
Misses 1293 1293
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@alexandear Thanks for the suggestions. I have changed the method names. Please let me know if you have any other suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra.
This is a good start. Please address the findings and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Thanks @gmlewis for the feedback! I have fixed all the findings. Sorry for the extra back and forth code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
github/secret_scanning.go
Outdated
if err != nil { | ||
return nil, nil, err | ||
} | ||
var reponsePushProtectionBypass *PushProtectionBypass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var reponsePushProtectionBypass *PushProtectionBypass | |
var responsePushProtectionBypass *PushProtectionBypass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexandear for spotting that! That was an accidental typo. I've fixed it.
Just FYI - suddenly I have lost write access to this repo, like in #3689... so I can no longer approve the workflows and need to find out what is going on... this may take some time to resolve... I apologize for the inconvenience. |
This PR adds support for two new Secret Scanning API endpoints that are currently missing from the
go-github
libraryImplement
POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypasses
GET /repos/{owner}/{repo}/secret-scanning/scan-history
Changes
CreatePushProtectionBypass
methodGetScanHistory
methodPushProtectionBypasses
method -PushProtectionBypassRequest
andPushProtectionBypass
ScanHistory
method -Scan
,CustomPatternScan
andSecretScanningResponse
Issue - #3686