Skip to content

chore: Format code with gofumpt #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandear
Copy link
Contributor

This PR enables gofumpt formatter and formats all code with golangci-lint fmt.

gofumpt detects missing empty lines between functions like in #3687 (comment)

Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, @alexandear! Thank you for doing this!
Of all the changes, the only one that I really don't like is the very last one: 0600 => 0o600 but I can live with that one. 😂

@gmlewis
Copy link
Contributor

gmlewis commented Aug 18, 2025

@willnorris - suddenly, with this one PR, I lost the ability to approve the two workflows above (EDIT:) below.
Are you able to tell if I am no longer officially a maintainer of this repo, or do I need to get the OSPO team involved?
Or maybe GitHub itself just had some sort of regression and I need to wait it out? 😂

EDIT: It looks like I may no longer have write access to the repo maybe? I'm not sure how I lost it.

@gmlewis
Copy link
Contributor

gmlewis commented Aug 18, 2025

Ah! I just received this email, which is BOGUS, as I have ALWAYS had two-factor authentication enabled ever since it was first introduced!!!

So I think GitHub itself just had a MAJOR regression, unfortunately.

BOGUS-2025-08-18_13-24-30 two-factor-proof-2025-08-18_13-26-17

@gmlewis
Copy link
Contributor

gmlewis commented Aug 18, 2025

@google-admin - could you please add me back to the "Google" organization for this repo, as GitHub seems to have had some sort of glitch that kicked me out.

@willnorris
Copy link
Collaborator

Yeah, that's weird. It looks like I have basically the same security config as you (couple of passkeys, etc), and I still have access. (Also, when did GitHub add Login with Google? That's interesting... I never noticed that before)

@gmlewis
Copy link
Contributor

gmlewis commented Aug 18, 2025

Yeah, that's weird. It looks like I have basically the same security config as you (couple of passkeys, etc), and I still have access.

Weird indeed. Thanks for the confirmation.

(Also, when did GitHub add Login with Google? That's interesting... I never noticed that before)

Actually, I don't even remember. It must have been years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants