refactor: enable gofmt linter
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
G-Rath
force-pushed
the
linting/enable-gofmt
branch
from
97eec00 to
88c387b
Compare
G-Rath
commented
Mar 25, 2025
| @@ -99,6 +99,8 @@ linters-settings: | |||
| - p: ^testing.T.Parallel$ | |||
| pkg: ^testing$ | |||
| analyze-types: true | |||
| gofmt: | |||
| simplify: false | |||
There was a problem hiding this comment.
@another-rex @erikvarga is this still a concern? it feels like the internal process in regards to these public linters has been improved (assumingly they're now blocking on internal changes?) as main has had a green tick for a number of merges.
Are we in a position where we could just start enforcing simplify now, or do we want to wait some more?
There was a problem hiding this comment.
Discussed offline, let's keep simplify as disabled.
G-Rath
force-pushed
the
linting/enable-gofmt
branch
from
88c387b to
3ace2a3
Compare
another-rex
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the linter without the simplify flag, meaning things like unneeded type declarations will not be considered violations - ideally we want to have that checked, but we need to ensure that will be enforced internally first
Relates to #274