Skip to content

refactor: enable gofmt linter #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

refactor: enable gofmt linter #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ linters:
- gocyclo
- godot
- godox
- gofmt # TODO(#274): work on enabling this
- gofumpt
- gosec # TODO(#274): work on enabling this
- ireturn
Expand Down Expand Up @@ -59,6 +58,8 @@ linters-settings:
- p: ^testing.T.Parallel$
pkg: ^testing$
analyze-types: true
gofmt:
simplify: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@another-rex @erikvarga is this still a concern? it feels like the internal process in regards to these public linters has been improved (assumingly they're now blocking on internal changes?) as main has had a green tick for a number of merges.

Are we in a position where we could just start enforcing simplify now, or do we want to wait some more?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, let's keep simplify as disabled.

revive:
rules:
- name: blank-imports
Expand Down