fix(web): bundle p-retry into dist/web browser build - #1835
Open
edenbuilds wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The web Rollup output left a bare "p-retry" import, which browsers cannot resolve. Resolve and inline p-retry for the web target only. Fixes googleapis#1330
edenbuilds
force-pushed
the
fix/web-bundle-p-retry-1330
branch
from
August 7, 2026 18:38
a7c3a41 to
60083da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rollup/plugin-node-resolveand no longer marksp-retryas external, sodist/web/index.mjshas no bare"p-retry"specifier.p-retry).Test plan
dist/web/index.mjscontainsfrom 'p-retry'; bundling withp-retryinlined removes that bare import.externalexcludesp-retry; plugins includenode-resolve.Fixes #1330