Skip to content

fix(web): bundle p-retry into dist/web browser build #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edenbuilds wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(web): bundle p-retry into dist/web browser build #1835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8b3d8d
fix(web): bundle p-retry into dist/web browser build
edenbuilds Aug 6, 2026
60083da
chore: retrigger Google CLA check after signing
edenbuilds Aug 7, 2026
7df9ec0
chore: sync with upstream main
omkar1work Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
"@microsoft/api-extractor": "^7.52.9",
"@modelcontextprotocol/sdk": "^1.25.2",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^16.0.3",
"@types/jasmine": "^5.1.2",
"@types/node": "^20.9.0",
"@types/node-fetch": "^2.6.13",
Expand Down
16 changes: 14 additions & 2 deletions rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json from '@rollup/plugin-json';
import resolve from '@rollup/plugin-node-resolve';
import {readFileSync} from 'fs';
import typescript from 'rollup-plugin-typescript2';

Expand Down Expand Up @@ -37,6 +38,17 @@ const externalDeps = [
'p-retry',
];

// Web builds must not leave bare npm specifiers — browsers cannot resolve them.
// Bundle `p-retry` into dist/web; keep other externals that are Node-only unused.
const webExternalDeps = externalDeps.filter((dep) => dep !== 'p-retry');
const webPlugins = [
...rollupPlugins,
resolve({
browser: true,
preferBuiltins: false,
}),
];

export default [
// Cross ES module (dist/index.mjs)
{
Expand Down Expand Up @@ -94,8 +106,8 @@ export default [
format: 'es',
sourcemap: true,
},
plugins: rollupPlugins,
external: externalDeps,
plugins: webPlugins,
external: webExternalDeps,
},

// The `tokenizer/node` ES module (dist/tokenizer/node.mjs)
Expand Down