feat(cdn): add KV_BASE_URL for CDN worker + add compatibility layer #7202

noghartt · 2025-10-30T18:53:16Z

Background

This PR adds a new env for KV_BASE_URL which will let both CF CDN worker + API custom providers work on self-hosted setup for CDN.

Also, it adds a guarantee that it won't create any breaking change considering the old value.

Description

We changed these services:

package/services/cdn-worker: add a new env KV_BASE_URL + expose a new field on function createIsKeyValid to let the user pass any string value to be used by artifact handler.
Fix packages/services/server to, when using API provider for CDN, it let the user insert any KV, for compatibility with their setup (if on self-hosted).

Checklist

System configuration

…PI provider

gemini-code-assist · 2025-10-30T18:53:34Z

Summary of Changes

Hello @noghartt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CDN worker and server configurations by introducing a new KV_BASE_URL environment variable. This allows self-hosted instances to specify a custom base URL for their Key-Value (KV) storage, improving flexibility for CDN providers (both Cloudflare worker and API-based). The changes are designed to be fully backward compatible, ensuring a smooth transition for existing deployments while expanding customization options for KV storage access.

Highlights

New KV Base URL Environment Variable: Introduced KV_STORAGE_BASE_URL for the CDN worker to allow custom KV storage endpoints.
Self-Hosted CDN Compatibility: Enables both Cloudflare CDN worker and API custom providers to work with self-hosted KV storage setups.
Backward Compatibility: Ensures that the changes do not introduce breaking changes for existing configurations.
Configurable Key Validation: The createIsKeyValid function now accepts an optional kvStorageBaseUrl to fetch schemas from a specified KV storage.
Server-Side Configuration: Added CDN_API_KV_BASE_URL and CDN_CF_KV_BASE_URL environment variables to the server for configuring KV base URLs for API and Cloudflare CDN providers, respectively.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a KV_BASE_URL environment variable for the CDN worker to allow custom KV storage endpoints, which is particularly useful for self-hosted setups. The changes span across the CDN worker and the server packages, adding the necessary configuration, type definitions, and logic to use the new variable while maintaining backward compatibility with a default URL.

My review has identified a critical syntax error that needs to be fixed, along with some medium-severity issues related to documentation accuracy, code maintainability (magic strings), and typos in comments. Overall, the changes are well-structured and address the intended feature.

packages/services/server/src/environment.ts

packages/services/cdn-worker/src/env.ts

packages/services/cdn-worker/src/index.ts

gemini-code-assist · 2025-10-30T18:55:07Z

packages/services/cdn-worker/src/key-validation.ts

      const cacheKey = new Request(
        [
-          'https://key-cache.graphql-hive.com',
+          args.kvStorageBaseUrl ?? 'https://key-cache.graphql-hive.com',


The default KV storage base URL 'https://key-cache.graphql-hive.com' is hardcoded here and again on line 155. To avoid magic strings and ensure consistency, it's better to define this as a constant at the top of the file and reuse it in both places.

For example:

const DEFAULT_KV_STORAGE_BASE_URL = 'https://key-cache.graphql-hive.com';

Then you can use it here and on line 155.

gemini-code-assist · 2025-10-30T18:55:07Z

packages/services/server/README.md

 | `S3_MIRROR_PUBLIC_URL`                      | No                                                   | The public URL of the S3, in case it differs from the `S3_ENDPOINT`.                                     | `http://localhost:8083`                              |
 | `CDN_API`                                   | No                                                   | Whether the CDN exposed via API is enabled.                                                              | `1` (enabled) or `0` (disabled)                      |
 | `CDN_API_BASE_URL`                          | No (Yes if `CDN_API` is set to `1`)                  | The public base url of the API service.                                                                  | `http://localhost:8082`                              |
+| `CDN_API_KV_BASE_URL`                       | No (**Optional** if `CDN_API` is set to `1`)         | The base URL for the KV for OIDC related endpoints.                                                      | `https://key-cache.graphql-hive.com`                 |


The description for CDN_API_KV_BASE_URL seems to be incorrect. It says it's for 'OIDC related endpoints', but based on the code changes, this URL is used for caching CDN access key validations. Please update the description to reflect its actual purpose.

This is true, the endpoint is not related to OIDC, only for caching

Gotcha, thought that there's some kind of relationship with the endpoint per se here.

gemini-code-assist · 2025-10-30T18:55:08Z

packages/services/server/README.md

 | `COMMERCE_ENDPOINT`       | **Yes**                              | The endpoint of the commerce service.                          | `http://127.0.0.1:4012`                             |
 | `CDN_CF`                  | No                                   | Whether the CDN is enabled.                                    | `1` (enabled) or `0` (disabled)                     |
 | `CDN_CF_BASE_URL`         | No (**Yes** if `CDN` is `1`)         | The base URL of the cdn.                                       | `https://cdn.graphql-hive.com`                      |
+| `CDN_CF_KV_BASE_URL`      | No (**Optional** if `CDN` is `1`)    | The base URL for the KV using CloudFlare provider              | `https://key-cache.graphql-hive.com`                |


The description for CDN_CF_KV_BASE_URL could be more specific. It's used for caching CDN access key validations. A more descriptive text would be helpful for users, for example: 'The base URL for the key-value store used for CDN access key validation caching when using the Cloudflare provider.'

This is true, it could be improved.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

n1ru4l · 2025-10-31T08:44:44Z

As a general question: what are the implications if you deploy this to your own cloudflare, with https://key-cache.graphql-hive.com hardcoded?

noghartt · 2025-10-31T15:38:07Z

As a general question: what are the implications if you deploy this to your own cloudflare, with https://key-cache.graphql-hive.com hardcoded?

From the tests I did in my self-hosted solution, it didn't work. So what I did was changing it in a similar way I did on this PR (without the conditional).

But not sure if you guys are using this URL for the caching yet or there's something new, I left it as the fallback, just in case to avoid any breaking change (even because there's a usage of it on the server).

noghartt added 3 commits October 30, 2025 15:48

feat(cdn): add env for KV_BASE_URL flow on key-validation

1362e23

feat(cdn): expose an env to manage KV URL compatibility with CDN on A…

ae680d7

…PI provider

docs(cdn): update doc with new envs related to KV_BASE_URL

8876c6a

noghartt mentioned this pull request Oct 30, 2025

Self-hosted CDN worker should have an env for KV cache URL (CloudFlare R2) #7036

Open

gemini-code-assist bot reviewed Oct 30, 2025

View reviewed changes

noghartt and others added 3 commits October 30, 2025 15:55

style: fix typo on environment setup

0ddbe0f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

docs: fix typo on env documentation

d5664bf

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

docs: fix typo on env documentation

e9a70c2

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

docs(server): improve description of CDN base URL envs

1fc67e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cdn): add KV_BASE_URL for CDN worker + add compatibility layer #7202

feat(cdn): add KV_BASE_URL for CDN worker + add compatibility layer #7202

Uh oh!

noghartt commented Oct 30, 2025

Uh oh!

gemini-code-assist bot commented Oct 30, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 30, 2025

Uh oh!

gemini-code-assist bot Oct 30, 2025

Uh oh!

n1ru4l Oct 31, 2025

Uh oh!

noghartt Oct 31, 2025

Uh oh!

gemini-code-assist bot Oct 30, 2025

Uh oh!

n1ru4l Oct 31, 2025

Uh oh!

n1ru4l commented Oct 31, 2025

Uh oh!

noghartt commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

feat(cdn): add KV_BASE_URL for CDN worker + add compatibility layer #7202

Are you sure you want to change the base?

feat(cdn): add KV_BASE_URL for CDN worker + add compatibility layer #7202

Uh oh!

Conversation

noghartt commented Oct 30, 2025

Background

Description

Checklist

Uh oh!

gemini-code-assist bot commented Oct 30, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

noghartt Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l commented Oct 31, 2025

Uh oh!

noghartt commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants