-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(@graphiql/react): migrate React context to zustand. Replace useExecutionContext
with useExecutionStore
hook and replace useEditorContext
with useEditorStore
hook
#3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 190130b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared
|
Wow...what a load of work, well done! Just pulled your branch down and looking through things. How do you feel about organizing the stores as such? For example, moving the execution store creation/state/actions out of |
Hey Jonathan, of course, there will be reorganisation, for now I just wanted to do my changes as close as possible to the source location, to keep the git history :) |
yep, it was fixed in following up refactoring PR #3950, will fix it here too, about types check - it would be nice to add github action to run types:check with turbo across all packages |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage 63.94% 63.94%
=======================================
Files 35 35
Lines 3087 3087
Branches 948 950 +2
=======================================
Hits 1974 1974
Misses 1108 1108
Partials 5 5 🚀 New features to boost your workflow:
|
No description provided.