Skip to content

feat(@graphiql/react): migrate React context to zustand. Replace useExecutionContext with useExecutionStore hook and replace useEditorContext with useEditorStore hook #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 20, 2025

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 190130b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@graphiql/plugin-doc-explorer Patch
@graphiql/plugin-explorer Major
@graphiql/plugin-history Patch
@graphiql/react Minor
graphiql Minor
@graphiql/plugin-code-exporter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina mentioned this pull request May 12, 2025
20 tasks
Base automatically changed from v4-5 to main May 13, 2025 16:13
Copy link
Contributor

github-actions bot commented May 13, 2025

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@dimaMachina dimaMachina marked this pull request as ready for review May 13, 2025 22:51
@jonathanawesome
Copy link
Collaborator

Wow...what a load of work, well done!

Just pulled your branch down and looking through things. How do you feel about organizing the stores as such? For example, moving the execution store creation/state/actions out of execution.tsx and into a stores folder?

@dimaMachina
Copy link
Collaborator Author

Wow...what a load of work, well done!

Just pulled your branch down and looking through things. How do you feel about organizing the stores as such? For example, moving the execution store creation/state/actions out of execution.tsx and into a stores folder?

Hey Jonathan, of course, there will be reorganisation, for now I just wanted to do my changes as close as possible to the source location, to keep the git history :)

@jonathanawesome
Copy link
Collaborator

Looks like there's an old export from this file that's breaking (also exported here).

Perhaps we should run types:check along with the build ("build": "yarn types:check && vite build")?

@dimaMachina
Copy link
Collaborator Author

Looks like there's an old export from this file that's breaking (also exported here).

Perhaps we should run types:check along with the build ("build": "yarn types:check && vite build")?

yep, it was fixed in following up refactoring PR #3950, will fix it here too,

about types check - it would be nice to add github action to run types:check with turbo across all packages

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.94%. Comparing base (fdc0a4f) to head (190130b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3946   +/-   ##
=======================================
  Coverage   63.94%   63.94%           
=======================================
  Files          35       35           
  Lines        3087     3087           
  Branches      948      950    +2     
=======================================
  Hits         1974     1974           
  Misses       1108     1108           
  Partials        5        5           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dimaMachina dimaMachina merged commit 71755b7 into main May 20, 2025
15 checks passed
@dimaMachina dimaMachina deleted the v4-6 branch May 20, 2025 18:53
@acao acao mentioned this pull request May 20, 2025
@dimaMachina dimaMachina mentioned this pull request May 20, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants