chore(binstall): standardize on zip for Windows artifacts#156
Merged
Conversation
Aligns greentic-dev's Windows release artifacts with the fleet-wide convention used by the user-facing CLIs (gtc, greentic-bundle, greentic-coding-agent, greentic-dwbase, greentic-i18n). Changes: - Workflow caller: add windows-archive-format: zip so the tag-triggered release-binaries job produces .zip for x86_64- and aarch64-pc-windows-msvc. - Cargo.toml: add [package.metadata.binstall.overrides.*-pc-windows-msvc] blocks so cargo binstall resolves to .zip on Windows. Depends on greenticai/.github#173 (merged), which fixes Compress-Archive's wrap-dir behavior so the .zip layout matches binstall's bin-dir template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-archive-format: zipso the tag-triggered release-binaries job produces.zipfor both Windows targets.Cargo.toml: add[package.metadata.binstall.overrides.*-pc-windows-msvc]blocks socargo binstallresolves to.zipon Windows.Why
Aligns this repo with the fleet-wide convention used by user-facing CLIs (gtc, greentic-bundle, greentic-coding-agent, greentic-dwbase, greentic-i18n) and with the Rust CLI ecosystem at large (ripgrep, fd, hyperfine all ship
.zipon Windows). Manual GitHub Release downloads on Windows become a one-click Explorer extraction.Depends on
greenticai/.github#173 (merged) — Compress-Archive wrap-dir fix; required for the produced
.ziplayout to match binstall'sbin-dirtemplate.Test plan
v*tag emitsgreentic-dev-v{version}-x86_64-pc-windows-msvc.zipand the matching aarch64 zipgreentic-dev-v{version}-{target}/directory holdinggreentic-dev.execargo binstall greentic-devon Windows resolves the zip and installs without falling back to source build