-
Notifications
You must be signed in to change notification settings - Fork 0
docs: add contributing guidelines and PR title format guide #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: groupthinking <[email protected]>
Co-authored-by: groupthinking <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR establishes comprehensive contribution documentation to address PR #4's non-compliant PR title format. Rather than enforcing strict rules through workflow modifications, it provides clear guidelines and templates to help contributors follow conventional commits format.
Changes:
- Creates CONTRIBUTING.md with full contribution guidelines including conventional commits format, code style references, and PR best practices
- Adds .github/PR_TITLE_GUIDE.md as a quick reference for PR title formatting with examples and a comparison table
- Adds .github/pull_request_template.md to provide a structured template for all new PRs with checklists
- Updates README.md with a Contributing section linking to the new documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds Contributing section with links to contribution guidelines |
| CONTRIBUTING.md | Comprehensive contribution guidelines covering conventional commits, PR format, code style, and testing |
| .github/PR_TITLE_GUIDE.md | Quick reference guide for PR title formatting with type table and common scenarios |
| .github/pull_request_template.md | Standardized PR template with checklist items and conventional commits reminder |
| We welcome contributions! Please see [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on: | ||
| - PR title format (conventional commits) | ||
| - Code style and conventions | ||
| - Testing requirements | ||
| - How to submit pull requests | ||
|
|
||
| For quick reference on PR titles, see [.github/PR_TITLE_GUIDE.md](.github/PR_TITLE_GUIDE.md). |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links in README.md use relative paths (e.g., CONTRIBUTING.md, .github/PR_TITLE_GUIDE.md), but files in .github/ (pull_request_template.md and PR_TITLE_GUIDE.md) use absolute paths starting with / (e.g., /CONTRIBUTING.md). For consistency and reliable rendering across GitHub's web interface, consider using absolute paths in README.md as well:
[CONTRIBUTING.md](/CONTRIBUTING.md)[.github/PR_TITLE_GUIDE.md](/.github/PR_TITLE_GUIDE.md)
This ensures the links work correctly whether viewed from the repository root or from within subdirectories in GitHub's web interface.
| We welcome contributions! Please see [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on: | |
| - PR title format (conventional commits) | |
| - Code style and conventions | |
| - Testing requirements | |
| - How to submit pull requests | |
| For quick reference on PR titles, see [.github/PR_TITLE_GUIDE.md](.github/PR_TITLE_GUIDE.md). | |
| We welcome contributions! Please see [CONTRIBUTING.md](/CONTRIBUTING.md) for guidelines on: | |
| - PR title format (conventional commits) | |
| - Code style and conventions | |
| - Testing requirements | |
| - How to submit pull requests | |
| For quick reference on PR titles, see [.github/PR_TITLE_GUIDE.md](/.github/PR_TITLE_GUIDE.md). |
Addresses unresolved review comments from PRs #6, #13, #25, #26: - src/index.ts: Add console.log→stderr redirect with unknown[] type - src/services/xapi.ts: Use URLSearchParams, add Array.isArray guard, add since_id pagination, use unknown type, avoid mutating sort - src/services/agent.ts: Add bounded memory pruning with safe iterator, process mentions oldest-first for chronological ordering - .github/workflows: Add permissions blocks, check labels exist before adding, use pull_request_target for fork PR support - README.md: Add Contributing section with absolute paths - Add CONTRIBUTING.md, PR_TITLE_GUIDE.md, pull_request_template.md Co-authored-by: groupthinking <[email protected]>
Description
Addresses PR #4 feedback about non-compliant PR title format. Creates documentation infrastructure for conventional commits instead of modifying workflow rules.
Motivation
PR validation workflow warns when titles don't follow conventional commits format (
feat:,fix:,docs:, etc.). The workflow already treats this as a warning (not error), so documentation provides the path of least resistance.Changes
For PR #4 specifically, recommended title:
Related Issues
Addresses review comment from PR #4: #4 (comment)
Testing
Checklist
feat:,fix:,docs:)Screenshots / Logs (if applicable)
N/A - Documentation only changes
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.