Fix 1097 - typescript: add missing constructor definition in generated message classes. #1515
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1097 by adding a missing constructor definition to generated TypeScript message classes. The change ensures that generated .d.ts files include an explicit constructor signature for classes extending jspb.Message.
- Adds constructor definition with optional
AsObjectparameter to generated TypeScript declaration files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| printer->Indent(); | ||
|
|
||
| printer->Print(vars, "constructor(opt_data?: $class_name$.AsObject);\n"); | ||
|
|
There was a problem hiding this comment.
Trailing whitespace on line 826 should be removed to maintain code cleanliness and comply with most style guides.
| printer->Print(vars, "export class $class_name$ extends jspb.Message {\n"); | ||
| printer->Indent(); | ||
|
|
||
| printer->Print(vars, "constructor(opt_data?: $class_name$.AsObject);\n"); |
There was a problem hiding this comment.
@Vuhag123 Thanks! for the change!
One request: Can you provide an example output in the PR description, and try verifying this change works (via a typescript example)?
There was a problem hiding this comment.
I have verified with typescript example it is working, i am attaching the images here too
Below is existing one:
After fix,
There was a problem hiding this comment.
Oh nice! This is great! Thanks for showing the change in action! This would be helpful indeed! Thanks Vuha :)
2 participants
Fix (#1097) - typescript: add missing constructor definition in generated message classes.