Skip to content

Fix 1097 - typescript: add missing constructor definition in generated message classes. #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vuhag123 wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix 1097 - typescript: add missing constructor definition in generated message classes. #1515

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
023c9f3
Bump version to 2.0.2
Vuhag123 Sep 15, 2025
d0ea705
Revert "Bump version to 2.0.2"
Vuhag123 Sep 15, 2025
ea2d8da
Reapply "Bump version to 2.0.2"
Vuhag123 Sep 16, 2025
4599312
Post-release updates (2.0.2)
Vuhag123 Sep 17, 2025
caf8a68
Merge branch 'grpc:master' into master
Vuhag123 Sep 17, 2025
a318a44
changed release note
Vuhag123 Sep 18, 2025
b032755
Merge branch 'grpc:master' into master
Vuhag123 Oct 8, 2025
75a6ba0
1057 - typescript: add missing constructor definition in generated me…
Vuhag123 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions javascript/net/grpc/web/generator/grpc_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,9 @@ void PrintProtoDtsMessage(Printer* printer, const Descriptor* desc,

printer->Print(vars, "export class $class_name$ extends jspb.Message {\n");
printer->Indent();

printer->Print(vars, "constructor(opt_data?: $class_name$.AsObject);\n");
Copy link
Collaborator

@sampajano sampajano Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vuhag123 Thanks! for the change!

One request: Can you provide an example output in the PR description, and try verifying this change works (via a typescript example)?

Copy link
Collaborator Author

@Vuhag123 Vuhag123 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified with typescript example it is working, i am attaching the images here too
Below is existing one:
Before_1097
After fix,
After_1097

Copy link
Collaborator

@sampajano sampajano Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! This is great! Thanks for showing the change in action! This would be helpful indeed! Thanks Vuha :)


Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace on line 826 should be removed to maintain code cleanliness and comply with most style guides.

Suggested change

Copilot uses AI. Check for mistakes.
for (int i = 0; i < desc->field_count(); i++) {
const FieldDescriptor* field = desc->field(i);
vars["js_field_name"] = JSFieldName(field);
Expand Down