Enumerate variables needed by the HTCondor workflow#376
Closed
duncanmmacleod wants to merge 3 commits intogwpy:masterfrom
Closed
Enumerate variables needed by the HTCondor workflow#376duncanmmacleod wants to merge 3 commits intogwpy:masterfrom
duncanmmacleod wants to merge 3 commits intogwpy:masterfrom
Conversation
instead enumerate the variables we want to propagate from the submit environment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 50.27% 49.65% -0.62%
==========================================
Files 60 60
Lines 8677 8824 +147
==========================================
+ Hits 4362 4381 +19
- Misses 4315 4443 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@duncanmmacleod Thanks, do we also need |
Member
Author
I don't see any references to |
Collaborator
@duncanmmacleod the reason I ask is because the code wants to get the conda environment used at the time pages are generated. Like here: https://github.com/gwdetchar/gwdetchar/blob/f79547a178c16b9a6b9626d23d656fb025c10338/gwdetchar/io/html.py#L51. Wouldn't this mean we need |
so that it is available in conda to generate the package list
Member
Author
I have added |
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
May 7, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
May 8, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375
Collaborator
|
I'll close this PR as I'd like to use #429 instead. I hope to be able to remove |
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 3, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 18, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 18, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 18, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 19, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 19, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 19, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
pushed a commit
to eagoetz/gwsumm
that referenced
this pull request
Nov 19, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes gwpy#375 # Conflicts: # gwsumm/batch.py
eagoetz
added a commit
that referenced
this pull request
Nov 25, 2025
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by #376, but I wanted to keep the existing code as simple as possible to avoid confusion. Closes #375 Co-authored-by: Evan Goetz <evan.goetz@ligo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #375 by replacing the use of
getenv=truewith a hardcoded set of environment variables to pass through from the submit environment.