Skip to content

Comments

Add environment variables to submit jobs#429

Merged
eagoetz merged 1 commit intogwpy:masterfrom
eagoetz:env-vars
Nov 25, 2025
Merged

Add environment variables to submit jobs#429
eagoetz merged 1 commit intogwpy:masterfrom
eagoetz:env-vars

Conversation

@eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented May 7, 2025

See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by #376, but I wanted to keep the existing code as simple as possible to avoid confusion.

An example summary page: https://ldas-jobs.ligo-wa.caltech.edu/~evan.goetz/summary/day/20251102/

Note that we need to add some variables in the summary page configuration: MPLCONFIGDIR, GWPY_RCPARAMS, GWPY_USETEX, MATPLOTLIBRC, and XDG_DATA_HOME. This will be done in a separate MR in that repository

Closes #375

@eagoetz eagoetz added this to the 2.3.2 milestone May 7, 2025
@eagoetz eagoetz self-assigned this May 7, 2025
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.25%. Comparing base (2c205e5) to head (78c6d4c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   49.22%   49.25%   +0.03%     
==========================================
  Files          60       60              
  Lines        8801     8804       +3     
==========================================
+ Hits         4332     4336       +4     
+ Misses       4469     4468       -1     
Flag Coverage Δ
Linux-python3.10 49.25% <100.00%> (+0.03%) ⬆️
Linux-python3.11 49.25% <100.00%> (+0.03%) ⬆️
macOS-python3.10 49.25% <100.00%> (+0.03%) ⬆️
macOS-python3.11 49.25% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eagoetz eagoetz modified the milestones: 2.3.2, 2.3.3 May 14, 2025
@eagoetz eagoetz modified the milestones: 2.3.3, 2.4.0 Jun 5, 2025
@eagoetz eagoetz force-pushed the env-vars branch 4 times, most recently from 419c257 to 2f4c453 Compare November 19, 2025 17:07
@eagoetz eagoetz force-pushed the env-vars branch 2 times, most recently from 44531c0 to 535f008 Compare November 19, 2025 21:32
See https://computing.docs.ligo.org/guide/htcondor/environment/?h=getenv#getenv. This PR is inspired by gwpy#376, but I wanted to keep the existing code as simple as possible to avoid confusion.

Closes gwpy#375

# Conflicts:
#	gwsumm/batch.py
Copy link
Collaborator

@areeda areeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eagoetz eagoetz merged commit f52de57 into gwpy:master Nov 25, 2025
8 checks passed
@eagoetz eagoetz deleted the env-vars branch November 25, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove getenv=true as a (default) condor_submit command

2 participants