Skip to content

add closed tag to Hack for LA project - #8835

Merged
castillios merged 1 commit into
hackforla:gh-pagesfrom
yepezjuan:closed-option-projectstatus-8776
Oct 17, 2026
Merged

castillios merged 1 commit into
hackforla:gh-pagesfrom
yepezjuan:closed-option-projectstatus-8776

Conversation

@yepezjuan

@yepezjuan yepezjuan commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Fixes #8776

What changes did you make?

  • Added the new "Closed" project status label by updating statusList in assets/js/current-projects.js
  • Updated the status label color variables for the "Closed" and "Completed" labels
  • Implemented the updated variables by navigating to the three files:
    - _sass/components/_projects.scss
    - _sass/components/_projects-page.scss
    - _sass/components/_home.scss

Why did you make the changes (we will use this info to test)?

  • We needed there to be an option for closed projects that were not completed
  • Created the distinction between completed projects and closed projects

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Before changes Screenshot 2026-10-14 at 8 03 14 PM
Visuals after changes are applied After changes Screenshot 2026-10-14 at 8 06 09 PM

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b yepezjuan-closed-option-projectstatus-8776 gh-pages
git pull https://github.com/yepezjuan/website.git closed-option-projectstatus-8776

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Oct 14, 2026

@Tomomi-K1 Tomomi-K1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look great! Thank you for taking up this task!

  • confirmed changes on my local env and fixes are correctly applied.
  • merging into correct branch

Small fixes I would recommend:

  • Make the title of this PR shorter since the end of the title seems to be cut off.
  • make sure to check all the check box in issue ticket: "Verify the changes by viewing the following in your local environment with Docker and include before and after screenshots with your pull request:"

@computarisis
computarisis self-requested a review October 14, 2026 01:47
@anthonylo87
anthonylo87 self-requested a review October 14, 2026 02:05
@anthonylo87

Copy link
Copy Markdown
Member

Availability: M-F
ETA: 10/14 EOD

@HackforLABot HackforLABot mentioned this pull request Oct 14, 2026
16 of 34 tasks
@computarisis

Copy link
Copy Markdown
Member

Review ETA: 10/15/2026 , 8PM ET
Availability: Everyday (8 pm - 11 pm)

@anthonylo87 anthonylo87 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yepezjuan,

Thanks for working on this issue. Although not explicitly stated in the issue - the change that's being implemented as a part of this issue updates the background color on the .status-Completed class from salmon to pale blue.

In your PR, can you please include screenshots to test these changes as well? Thank you!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Oct 14, 2026
@yepezjuan yepezjuan changed the title added a grey closed tag to Hack for LA project. Also modified the Com… add closed tag to Hack for LA project. Also modified the Com… Oct 15, 2026
@yepezjuan yepezjuan changed the title add closed tag to Hack for LA project. Also modified the Com… add closed tag to Hack for LA project Oct 15, 2026
@yepezjuan

Copy link
Copy Markdown
Member Author

Hi @anthonylo87 ,

Thank you for catching that. It definitely helps to document that piece of the change as well. Let me know what you think about the photos I added

@anthonylo87
anthonylo87 self-requested a review October 15, 2026 19:52

@anthonylo87 anthonylo87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - please see Tomomi's note above, not a huge deal bit be sure to tick the box in your issue #8776 so that the teams is aware that you've gone through all the steps in the issue

"make sure to check all the check box in issue ticket: "Verify the changes by viewing the following in your local environment with Docker and include before and after screenshots with your pull request:"

@github-project-automation github-project-automation Bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 15, 2026

@computarisis computarisis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm you did:
Check off the prescribed steps
Add the colors and styling as indicated
Add the 'closed' option
I've verified the changes locally by changing the status variable for other projects and validating the expected frontend behavior. Good job!

@castillios

Copy link
Copy Markdown
Member

Hi @yepezjuan and reviewers! I've double checked everything and the changes look great. Thank you Juan for your work on this issue, and thank you reviewers for leaving thorough comments. Merging this PR now.

@castillios
castillios merged commit c77f3ea into hackforla:gh-pages Oct 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Projects Pages: Update Project Status Options and Label Color

5 participants