Repository navigation
add closed tag to Hack for LA project - #8835
Conversation
…pleted tags color from salmon to blue
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Tomomi-K1
left a comment
There was a problem hiding this comment.
Changes all look great! Thank you for taking up this task!
- confirmed changes on my local env and fixes are correctly applied.
- merging into correct branch
Small fixes I would recommend:
- Make the title of this PR shorter since the end of the title seems to be cut off.
- make sure to check all the check box in issue ticket: "Verify the changes by viewing the following in your local environment with Docker and include before and after screenshots with your pull request:"
|
Availability: M-F |
|
Review ETA: 10/15/2026 , 8PM ET |
There was a problem hiding this comment.
Hi @yepezjuan,
Thanks for working on this issue. Although not explicitly stated in the issue - the change that's being implemented as a part of this issue updates the background color on the .status-Completed class from salmon to pale blue.
In your PR, can you please include screenshots to test these changes as well? Thank you!
|
Hi @anthonylo87 , Thank you for catching that. It definitely helps to document that piece of the change as well. Let me know what you think about the photos I added |
anthonylo87
left a comment
There was a problem hiding this comment.
Approved - please see Tomomi's note above, not a huge deal bit be sure to tick the box in your issue #8776 so that the teams is aware that you've gone through all the steps in the issue
"make sure to check all the check box in issue ticket: "Verify the changes by viewing the following in your local environment with Docker and include before and after screenshots with your pull request:"
computarisis
left a comment
There was a problem hiding this comment.
I can confirm you did:
Check off the prescribed steps
Add the colors and styling as indicated
Add the 'closed' option
I've verified the changes locally by changing the status variable for other projects and validating the expected frontend behavior. Good job!
|
Hi @yepezjuan and reviewers! I've double checked everything and the changes look great. Thank you Juan for your work on this issue, and thank you reviewers for leaving thorough comments. Merging this PR now. |
Fixes #8776
What changes did you make?
-
_sass/components/_projects.scss-
_sass/components/_projects-page.scss-
_sass/components/_home.scssWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied