update gateway-services table with endpoints #13217
Conversation
dhiaayachi
added
pr/no-changelog
dhiaayachi
requested review from
a team and
rboyer
and removed request for
a team
…r a service or a destination exist)
rename "endpoint" to "destination"
Co-authored-by: Dan Stough <[email protected]>
|
|
||
| } | ||
|
|
||
| func TestStore_ServiceDefaults_Kind_Destination(t *testing.T) { |
There was a problem hiding this comment.
I should probably do an actual diff, but just looking at TestStore_ServiceDefaults_isDestination above and this function, I didn't see the difference.
|
|
||
| } | ||
|
|
||
| func TestStore_ServiceDefaults_Kind_Destination_Wildcard(t *testing.T) { |
There was a problem hiding this comment.
Same comment here about redundancy with TestStore_ServiceDefaults_isDestination_Wildcard
There was a problem hiding this comment.
right all the isDestination tests are duplicate. I will remove them
Co-authored-by: Dan Stough <[email protected]>
| } | ||
| if sd.Destination != nil { | ||
| return structs.GatewayServiceKindDestination, nil | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
| return structs.GatewayServiceKindService, nil |
Would this be appropriate? Or are you elsewhere going to interpret "unknown" as "service"?
There was a problem hiding this comment.
The reason I added the unknown kind is to differentiate between existing services/destinations and references in the tgtw to non existing, it will help for debugging purpose.
Description
This part of the work needed to add destinations (formerly endpoints) to the terminating gateway. Destinations are defined using a service-default config entry and represent an external entity (a set of addresses and a port) which can be reachable through a given terminating gateway.
In this PR we add the association between a given destination and a terminating gateway. This include the use case of a terminating gateway that define a wildcard in his LinkedServices.
We also add a filed that define the kind of the mapping (Unknown, Service or Destination) so that could be used in the proxycfg part to define the right envoy config.
The Kind is updated based on Service and Destination CRUD and if a Service and a Destination with the same name exists priority is given to the Service.
PR Checklist