Indoor map example update based on user feedback #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnativ13
force-pushed
the
indoor-map-example-update-based-on-user-feedback
branch
from
cb2788c to
7052ddb
Compare
|
Hi @dbacarel - so this is the new PR. Can you please review it? |
dbacarel
requested changes
Feb 14, 2023
indoor-map/demo.js
Outdated
| function addVenueToMap(map, platform) { | ||
| // Indoor Maps provider interacts with a tile layer to visualize and control the Indoor Map | ||
| const venuesProvider = new H.venues.Provider(); | ||
|
|
||
| // Get an instance of the Indoor Maps service using a valid apikey for Indoor Maps | ||
| const venuesService = platform.getVenuesService({ apikey: yourApikey, hrn: indoorMapHrn }, 2); | ||
|
|
There was a problem hiding this comment.
why was the call to getMapInfoList removed?
There was a problem hiding this comment.
I'm not sure about this one. The change was part of a recommendation I received from Andrii Heonia.
hnativ13
force-pushed
the
indoor-map-example-update-based-on-user-feedback
branch
from
958b52b to
4e2e074
Compare
…apInfoList() (heremaps#143)" (heremaps#144) This reverts commit 9f4b3ab. Signed-off-by: Intellias\ihnativ <[email protected]>
…foList This reverts commit fdfe8bc. Signed-off-by: Intellias\ihnativ <[email protected]>
More information on the use of the HERE Indoor Maps API now points at the correct link. Signed-off-by: Intellias\ihnativ <[email protected]>
The variable platform was missing from the function addVenueToMap Signed-off-by: Intellias\ihnativ <[email protected]>
The drawingId variable in the example wasn't defined as optional, whereas it is such according to the user feedaback. Signed-off-by: Intellias\ihnativ <[email protected]>
There's now a reference to the description of optional variables mentioned in the example. Signed-off-by: Intellias\ihnativ <[email protected] Signed-off-by: Intellias\ihnativ <[email protected]>
This reverts commit b729568. Signed-off-by: Intellias\ihnativ <[email protected]>
hnativ13
force-pushed
the
indoor-map-example-update-based-on-user-feedback
branch
from
41ebdca to
919309d
Compare
|
@hnativ13 the history is once again compromised + your previous changes about passing |
Oh my, sorry, I thought this was the one you requested to revert. Shall I commit it again? |
hnativ13
deleted the
indoor-map-example-update-based-on-user-feedback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.