-
Notifications
You must be signed in to change notification settings - Fork 429
Indoor map example update based on user feedback #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indoor map example update based on user feedback #147
Conversation
cb2788c
to
7052ddb
Compare
Hi @dbacarel - so this is the new PR. Can you please review it? |
indoor-map/demo.js
Outdated
function addVenueToMap(map, platform) { | ||
// Indoor Maps provider interacts with a tile layer to visualize and control the Indoor Map | ||
const venuesProvider = new H.venues.Provider(); | ||
|
||
// Get an instance of the Indoor Maps service using a valid apikey for Indoor Maps | ||
const venuesService = platform.getVenuesService({ apikey: yourApikey, hrn: indoorMapHrn }, 2); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was the call to getMapInfoList
removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one. The change was part of a recommendation I received from Andrii Heonia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
958b52b
to
4e2e074
Compare
…apInfoList() (heremaps#143)" (heremaps#144) This reverts commit 9f4b3ab. Signed-off-by: Intellias\ihnativ <[email protected]>
…foList This reverts commit fdfe8bc. Signed-off-by: Intellias\ihnativ <[email protected]>
More information on the use of the HERE Indoor Maps API now points at the correct link. Signed-off-by: Intellias\ihnativ <[email protected]>
The variable platform was missing from the function addVenueToMap Signed-off-by: Intellias\ihnativ <[email protected]>
The drawingId variable in the example wasn't defined as optional, whereas it is such according to the user feedaback. Signed-off-by: Intellias\ihnativ <[email protected]>
There's now a reference to the description of optional variables mentioned in the example. Signed-off-by: Intellias\ihnativ <[email protected] Signed-off-by: Intellias\ihnativ <[email protected]>
This reverts commit b729568. Signed-off-by: Intellias\ihnativ <[email protected]>
41ebdca
to
919309d
Compare
@hnativ13 the history is once again compromised + your previous changes about passing |
Oh my, sorry, I thought this was the one you requested to revert. Shall I commit it again? |
No description provided.