Skip to content

Indoor map example update based on user feedback #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hnativ13
Copy link

@hnativ13 hnativ13 commented Feb 9, 2023

No description provided.

@hnativ13 hnativ13 force-pushed the indoor-map-example-update-based-on-user-feedback branch from cb2788c to 7052ddb Compare February 9, 2023 12:55
@hnativ13
Copy link
Author

Hi @dbacarel - so this is the new PR. Can you please review it?

function addVenueToMap(map, platform) {
// Indoor Maps provider interacts with a tile layer to visualize and control the Indoor Map
const venuesProvider = new H.venues.Provider();

// Get an instance of the Indoor Maps service using a valid apikey for Indoor Maps
const venuesService = platform.getVenuesService({ apikey: yourApikey, hrn: indoorMapHrn }, 2);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the call to getMapInfoList removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one. The change was part of a recommendation I received from Andrii Heonia.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hnativ13 hnativ13 force-pushed the indoor-map-example-update-based-on-user-feedback branch from 958b52b to 4e2e074 Compare February 15, 2023 08:26
dbacarel and others added 7 commits February 16, 2023 13:54
…foList

This reverts commit fdfe8bc.

Signed-off-by: Intellias\ihnativ <[email protected]>
More information on the use of the HERE Indoor Maps API now points at the correct link.

Signed-off-by: Intellias\ihnativ <[email protected]>
The variable platform was missing from the function addVenueToMap

Signed-off-by: Intellias\ihnativ <[email protected]>
The drawingId variable in the example wasn't defined as optional, whereas it is such according to the user feedaback.

Signed-off-by: Intellias\ihnativ <[email protected]>
There's now a reference to the description of optional variables mentioned in the example.

Signed-off-by: Intellias\ihnativ <[email protected]
Signed-off-by: Intellias\ihnativ <[email protected]>
This reverts commit b729568.

Signed-off-by: Intellias\ihnativ <[email protected]>
@hnativ13 hnativ13 force-pushed the indoor-map-example-update-based-on-user-feedback branch from 41ebdca to 919309d Compare February 16, 2023 11:54
@dbacarel
Copy link
Member

@hnativ13 the history is once again compromised + your previous changes about passing platform instance to addVenueToMap are gone

@hnativ13
Copy link
Author

@hnativ13 the history is once again compromised + your previous changes about passing platform instance to addVenueToMap are gone

Oh my, sorry, I thought this was the one you requested to revert. Shall I commit it again?

@dbacarel
Copy link
Member

@hnativ13 , I created a separate branch with the expected changes #148 and merged it. Closing this one

@dbacarel dbacarel closed this Feb 20, 2023
@hnativ13 hnativ13 deleted the indoor-map-example-update-based-on-user-feedback branch February 20, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants