[codex] parse contact locations from adverts#143
Merged
hermes-gadget merged 1 commit intoMay 26, 2026
Conversation
hermes-gadget
approved these changes
May 26, 2026
Owner
hermes-gadget
left a comment
There was a problem hiding this comment.
Code review: ✅ Approved
Changes
- Adds , , fields to and
- Parses lat/lon from adverts when present; clears when omitted in later adverts (prevents stale data)
- Exports through for future UI use
- 45 lines of new tests covering store, clear-on-update, and struct field access
Verification
- ✅ 278/278 native tests passed (+1 expected skip)
- ✅ Firmware builds clean (59.9% RAM, 18.6% Flash)
- ✅ Version fix applied — branch had from fork drift, noted for post-merge cleanup
- ✅ No new warnings
Notes
- Clean additive change (79 additions, 0 deletions)
- Lambda avoids duplication across 3 call sites
- One minor: version regressed to — I'll fix on dev after merge
hermes-gadget
approved these changes
May 26, 2026
Owner
hermes-gadget
left a comment
There was a problem hiding this comment.
Code review: ✅ Approved
Changes
- Adds
has_location,latitude,longitudefields to SlopContact and ContactInfo - Parses lat/lon from adverts when present; clears when omitted in later adverts (prevents stale data)
- Exports through exportContactsFull() for future UI use
- 45 lines of new tests covering store, clear-on-update, and struct field access
Verification
- ✅ 278/278 native tests passed (+1 expected skip)
- ✅ Firmware builds clean (59.9% RAM, 18.6% Flash)
- ✅ Version fix applied — branch had beta-0.1.32 from fork drift, noted for post-merge cleanup
- ✅ No new warnings
Notes
- Clean additive change (79 additions, 0 deletions)
- Lambda update_location avoids duplication across 3 call sites
- One minor: version regressed to beta-0.1.32 — I'll fix on dev after merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #142.
Testing
Testing method: native tests only; hardware/firmware build still needs maintainer validation.
Notes
I attempted uvx --from platformio platformio run -e SlopOS_TDeck, but the fresh ESP32 build stayed CPU-active inside SCons dependency analysis for an extended period with no compile output, so I stopped it rather than treating it as a reliable validation result.
Checklist