fix: show radio setup warning in home top bar, remove channel hashtags#175
Merged
Conversation
Two UI changes to the top bar: 1. Radio setup warning — When prefs_get().configured is false, show a red 'Do setup for radio' message in the home screen top bar where channel hashtags used to be. Hidden when configured. 2. Remove channel hashtags from the top bar entirely (both home_screen and make_screen_full sub-screens). Channels are already accessible via the CHATS screen and clutter every page's header. Fixes #174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Changes
Radio setup warning — When
prefs_get().configuredis false, the home screen top bar shows "Do setup for radio" in red (instead of the old channel hashtag list). Hidden once the user configures radio params in Settings → Radio Setup.Remove channel hashtags — Channel hashtag string removed from both
home_screentop bar andmake_screen_fullsub-screen header. Channels are accessible in the CHATS screen and don't need to clutter every page.Testing
pio run -e SlopOS_TDeck— builds cleanpio test -e native_test— 293/294 pass (1 skip pre-existing)