Skip to content

refactor(repo): resolve changed-code audit#2174

Open
jrusso1020 wants to merge 1 commit into
07-10-test-engine-isolate-peer-abort-regressionfrom
07-10-refactor-repo-resolve-changed-code-audit
Open

refactor(repo): resolve changed-code audit#2174
jrusso1020 wants to merge 1 commit into
07-10-test-engine-isolate-peer-abort-regressionfrom
07-10-refactor-repo-resolve-changed-code-audit

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Resolve all changed-code findings introduced by the refactoring stack.

Why

A large safety-oriented stack should not add dead code, avoidable complexity, or duplicated test and helper logic.

How

Reuse the shared auth fixture, centralize the Cloud Run FPS helper and Studio persistence prop type, and add narrow documented suppressions only for intentional migration/test-corpus repetition.

Test plan

  • Fallow new-only gate: zero dead code, complexity, or duplication introduced
  • Focused affected tests, full pre-commit checks, and complete stack-wide validation

This was referenced Jul 10, 2026
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from 03defd0 to ba5d10b Compare July 13, 2026 18:35
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 996c416 to 665006e Compare July 13, 2026 18:35
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from ba5d10b to cb184e3 Compare July 13, 2026 20:27
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from f57212b to eea1424 Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from cb184e3 to 437f2fa Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from eea1424 to a66407f Compare July 13, 2026 22:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch 2 times, most recently from 0cd0d53 to 1f503e8 Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from a66407f to 3f82ade Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from 1f503e8 to 567d76c Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 195ebe8 to 7bc03fb Compare July 14, 2026 00:03
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch 2 times, most recently from 4614f85 to 4a63ab3 Compare July 14, 2026 03:20
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 7bc03fb to 519e384 Compare July 14, 2026 03:20
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from 4a63ab3 to ad7094b Compare July 14, 2026 17:03
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 4a63b75 to 5537a7f Compare July 14, 2026 17:11
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from ad7094b to 8095454 Compare July 14, 2026 17:11
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 5537a7f to 47c96ed Compare July 14, 2026 17:35
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from 8095454 to 03a10f4 Compare July 14, 2026 17:35
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 47c96ed to 9595995 Compare July 14, 2026 17:57
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch 2 times, most recently from 63add6a to b17e180 Compare July 14, 2026 18:06
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from a0c92bc to aadfd4d Compare July 14, 2026 19:37
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from b17e180 to 97014ce Compare July 14, 2026 19:37
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from aadfd4d to bc585c6 Compare July 14, 2026 19:42
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-repo-resolve-changed-code-audit branch from 97014ce to a4d798c Compare July 14, 2026 19:42
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from bc585c6 to 71575e2 Compare July 14, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant