[quality] fix nil-logger SIGSEGV in pkg/dashboard TestHandleRepoActivityReportsPhaseOneHonesty

[kubestellar-hive]

Test Improvement

Fixes a deterministic panic that fails the entire pkg/dashboard test binary on the default branch.

Files/functions claimed: src/pkg/dashboard/activity_collector_test.go — TestHandleRepoActivityReportsPhaseOneHonesty only. Disjoint from open PRs #4863 (src/pkg/dashboard/audit.go) and #4032 (proxy/github auth injection).

Problem

The test built the server with NewServer(0, nil). Server.RegisterAPI registers contribute routes, and NewContributeWSHub → loadCompletedTasks calls h.logger.Info(...) unconditionally, so the nil *slog.Logger crashes with a SIGSEGV:

--- FAIL: TestHandleRepoActivityReportsPhaseOneHonesty (0.01s)
panic: runtime error: invalid memory address or nil pointer dereference
  log/slog.(*Logger).Enabled ...
  dashboard.(*ContributeWSHub).loadCompletedTasks contribute_ws.go:1386
  dashboard.NewContributeWSHub contribute_ws.go:827
  dashboard.(*Server).RegisterAPI api.go:38

Fix

Pass an io.Discard slog logger, matching every other dashboard test that calls RegisterAPI (e.g. advisory_state_test.go, api_contribute_handler_branches_test.go).

Test-only change; no production code touched. Verified: go test -run 'TestHandleRepoActivity|TestActivityCollector' ./pkg/dashboard/ passes.

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.78

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Changelog: this PR changes code but does not touch CHANGELOG.md.

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a line under ## Unreleased. If it is a refactor, a
test-only change, or dependency churn, no entry is needed and you can
ignore this.

This is a reminder, not a gate; it never blocks a merge.

[github-actions]

Thank you for your contribution! Your PR has been merged.

Check out what's new:

• KubeStellar Console — Live multi-cluster dashboard
• Marketplace — Community extensions
• Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey