Skip to content

[ci-maintainer] fix: bounded retry for pinned go-licenses install in src/scripts/generate-notice.sh (NOTICE gate flake) - #5717

Closed
kubestellar-hive[bot] wants to merge 3 commits into
v4from
ci/fix-golicenses-install-retry
Closed

[ci-maintainer] fix: bounded retry for pinned go-licenses install in src/scripts/generate-notice.sh (NOTICE gate flake)#5717
kubestellar-hive[bot] wants to merge 3 commits into
v4from
ci/fix-golicenses-install-retry

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

CI Fix

Files claimed: src/scripts/generate-notice.sh only (the go install github.com/google/go-licenses@v1.6.0 step).

The Go Security Analysis job NOTICE matches the module graph runs this script, which did a single-shot go install. Transient sum.golang.org HTTP/2 stream errors (INTERNAL_ERROR) failed the gate on unrelated v4 pushes today — runs 33648244271 (15:23 UTC) and 33653482414 (16:12 UTC), both followed by clean greens.

This adds a bounded 3-attempt retry with linear backoff around the install command only. The exact version pin and all NOTICE-generation/comparison logic are unchanged.

Disjoint from open hold-gated PRs (#5713, #5697, #5642, #5635, #5559, #4032) and from #5692 (podman lanes) — none touch this script.

Refs #5716


Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5

…mdb errors

generate-notice.sh did a single-shot 'go install go-licenses@v1.6.0'; a
transient sum.golang.org HTTP/2 stream error failed the whole NOTICE gate
on unrelated pushes (runs 33648244271, 33653482414). Add a bounded
3-attempt retry with backoff around the install only — the version pin
and the NOTICE comparison logic are unchanged.

Refs #5716

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
@kubestellar-hive kubestellar-hive Bot added the hold label Sep 2, 2026
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
…gelog.d convention

changelog-fragment-guard requires the fragment's first line to be the
entry bullet itself; the compiler owns the headings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2026
@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

Closing: superseded by #5724, which landed the same bounded retry (3 attempts, linear backoff) for the pinned go-licenses install in src/scripts/generate-notice.sh on v4. Issue #5716 is resolved on the default branch; this PR now only produces a merge conflict against the landed fix.

Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. hold needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants