Skip to content

[ci-maintainer] fix: bounded retry for pinned go-licenses install in src/scripts/generate-notice.sh (NOTICE gate flake) #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kubestellar-hive wants to merge 3 commits into from
Closed

[ci-maintainer] fix: bounded retry for pinned go-licenses install in src/scripts/generate-notice.sh (NOTICE gate flake) #5717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f06a959
[ci-maintainer] fix: retry pinned go-licenses install on transient su…
Sep 2, 2026
0aa1ca8
[ci-maintainer] chore: changelog fragment for #5716 retry fix
Sep 2, 2026
a103828
[ci-maintainer] chore: make changelog fragment a '- ' bullet per chan…
Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-5716-golicenses-install-retry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Retry the pinned go-licenses install in `src/scripts/generate-notice.sh` (3 bounded attempts with backoff) so transient sum.golang.org stream errors no longer fail the NOTICE gate on unrelated pushes ([#5716](https://github.com/kubestellar/hive/issues/5716)).
17 changes: 16 additions & 1 deletion src/scripts/generate-notice.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,22 @@ if ! command -v go >/dev/null 2>&1; then
fi

echo "Installing go-licenses@${GO_LICENSES_VERSION} (pinned)..." >&2
go install "github.com/google/go-licenses@${GO_LICENSES_VERSION}"
# Bounded retry: sum.golang.org intermittently returns HTTP/2 stream errors
# (INTERNAL_ERROR) that fail an otherwise-deterministic pinned install and
# turn the NOTICE gate red on unrelated pushes (see issue #5716). The pin is
# untouched — only the network fetch gets resilience.
install_attempts=3
for attempt in $(seq 1 "${install_attempts}"); do
if go install "github.com/google/go-licenses@${GO_LICENSES_VERSION}"; then
break
fi
if [[ "${attempt}" -eq "${install_attempts}" ]]; then
echo "generate-notice.sh: go install go-licenses@${GO_LICENSES_VERSION} failed after ${install_attempts} attempts" >&2
exit 1
fi
echo "generate-notice.sh: go install attempt ${attempt}/${install_attempts} failed (likely transient module-proxy/sumdb error); retrying in $((attempt * 5))s..." >&2
sleep $((attempt * 5))
done

GOBIN="$(go env GOPATH)/bin"
GO_LICENSES_BIN="${GOBIN}/go-licenses"
Expand Down
Loading