Repository navigation
chore: the SDK whose iOS core is core-ios 0.1.0's prebuilt XCFramework, and the CLI at 4eba9a1 - #6
Merged
Merged
Conversation
…k, and the CLI at 4eba9a1 [skip ci] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The PR body lacks the required closing reference to the issue tracking the SDK/CLI update.
1 open issue
What changed in this PR
Updates the demo’s SDK and CLI pins, moving iOS core delivery to the SDK’s prebuilt core-ios 0.1.0 XCFramework.
Changes:
- Pins the SDK to
56112ddand CLI to4eba9a1, updating the npm lockfile. - Removes the direct
HotCodePushCoreCocoaPods pin and manually adjusts the native lockfile. - Updates contributor documentation to describe SDK-managed iOS core delivery.
| File | Description |
|---|---|
package.json |
Updates SDK and CLI commit pins. |
package-lock.json |
Records updated package resolutions and integrity hashes. |
ios/Podfile.lock |
Removes standalone core entries and updates the Podfile checksum. |
ios/Podfile |
Removes the direct iOS core dependency pin. |
CLAUDE.md |
Documents that the SDK pod carries the iOS core. |
Review effort: Balanced
| }, | ||
| "dependencies": { | ||
| "@hotcodepush/react-native-code-push": "https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@2143c58e5a5882df2bd2738f76f0fe2306180b28", | ||
| "@hotcodepush/react-native-code-push": "https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@56112dd6c11c88b320bf7ca390296e0862f3b27c", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the SDK commit whose iOS core is core-ios 0.1.0's prebuilt XCFramework, and the CLI at 4eba9a1 (no Podfile pin,
HOTCODEPUSH_API_URL). Lockfiles updated withnpm install --package-lock-only; native lockfiles edited by hand where they named the old core pin, refreshed by the nextpod install/ package resolution. Committed with[skip ci]; CI is dispatched on the branch.🤖 Generated with Claude Code