Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ Everything `npx hotcodepush init` adds to a React Native project is committed he

- `ios/HotCodePushDemo/AppDelegate.swift` returns `HotCodePush.bundleURL()` in release builds, and `android/.../MainApplication.kt` imports the SDK's `getDefaultReactHost`: React Native runs the bundle the SDK serves.
- The Xcode phase "Create HotCodePush binary", after "Bundle React Native code and images", and the `apply from` line at the end of `android/app/build.gradle` run the CLI's build step on what the build bundled: `binary create` in an Xcode archive or a Gradle build type other than `debug`, `resource-file write` in every other build.
- `ios/Podfile` pins `HotCodePushCore` at the commit the SDK names.

Both commands write `hotcodepush.json` into the app — the project's file plus `builtAt`, `fingerprint`, `embeddedBundleManifest` and `embeddedBundleId`; only `binary create` creates the store build's binary and versions the embedded manifest, `resource-file write` leaving `bundleVersion` empty and `embeddedBundleId` null. `binary create` needs a login or `HOTCODEPUSH_TOKEN`, and without one, or with `HOTCODEPUSH_OFFLINE=1`, the build names no channel and takes no updates.
A debug build bundles nothing and asks Metro for its JavaScript; the build step still writes its `hotcodepush.json`, without an embedded bundle, so every sync answers `skipped` with `build_debug`; the device test and a first try of an update use store builds, on iOS an archive, since a Release build creates no binary.
Expand All @@ -44,7 +43,7 @@ The Android manifest permits cleartext to `10.0.2.2` and `localhost` alone, and

## Dependencies during the build phase

The SDK is pinned to the pkg.pr.new build of one commit, `https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@<sha>`, never `@main`; a bump is one edit of that sha, and of the pod's commit in `ios/Podfile` when the SDK's `package.json` names another.
The SDK is pinned to the pkg.pr.new build of one commit, `https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@<sha>`, never `@main`; a bump is one edit of that sha, and the SDK's pod carries the iOS core.
The CLI is pinned the same way, `https://pkg.pr.new/hotcodepush-team/cli/hotcodepush@<sha>`.
Every other dependency is pinned to an exact version and bumped by Renovate.

Expand Down
1 change: 0 additions & 1 deletion ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ end

target 'HotCodePushDemo' do
config = use_native_modules!
pod 'HotCodePushCore', :git => 'https://github.com/hotcodepush-team/core-ios.git', :commit => '17a2cc92ac21c870cec9a5cfe32d427433bdfb70'

use_react_native!(
:path => config[:reactNativePath],
Expand Down
14 changes: 1 addition & 13 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ PODS:
- hermes-engine (0.82.1):
- hermes-engine/Pre-built (= 0.82.1)
- hermes-engine/Pre-built (0.82.1)
- HotCodePushCore (0.0.0)
- HotcodepushReactNativeCodePush (0.0.0):
- hermes-engine
- HotCodePushCore
- RCTRequired
- RCTTypeSafety
- React-Core
Expand Down Expand Up @@ -1711,7 +1709,6 @@ PODS:
DEPENDENCIES:
- FBLazyVector (from `../node_modules/react-native/Libraries/FBLazyVector`)
- hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
- HotCodePushCore (from `https://github.com/hotcodepush-team/core-ios.git`, commit `17a2cc92ac21c870cec9a5cfe32d427433bdfb70`)
- "HotcodepushReactNativeCodePush (from `../node_modules/@hotcodepush/react-native-code-push`)"
- RCTDeprecation (from `../node_modules/react-native/ReactApple/Libraries/RCTFoundation/RCTDeprecation`)
- RCTRequired (from `../node_modules/react-native/Libraries/Required`)
Expand Down Expand Up @@ -1788,9 +1785,6 @@ EXTERNAL SOURCES:
hermes-engine:
:podspec: "../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec"
:tag: hermes-2025-09-01-RNv0.82.0-265ef62ff3eb7289d17e366664ac0da82303e101
HotCodePushCore:
:commit: 17a2cc92ac21c870cec9a5cfe32d427433bdfb70
:git: https://github.com/hotcodepush-team/core-ios.git
HotcodepushReactNativeCodePush:
:path: "../node_modules/@hotcodepush/react-native-code-push"
RCTDeprecation:
Expand Down Expand Up @@ -1928,15 +1922,9 @@ EXTERNAL SOURCES:
Yoga:
:path: "../node_modules/react-native/ReactCommon/yoga"

CHECKOUT OPTIONS:
HotCodePushCore:
:commit: 17a2cc92ac21c870cec9a5cfe32d427433bdfb70
:git: https://github.com/hotcodepush-team/core-ios.git

SPEC CHECKSUMS:
FBLazyVector: 2e5b5553df729e080483373db6f045201ff4e6db
hermes-engine: 273e30e7fb618279934b0b95ffab60ecedb7acf5
HotCodePushCore: eb92d441bcc2030fcaf3c4bf460f523efc2ccbec
HotcodepushReactNativeCodePush: c8624706c3e9d20c2e7501b60aab2276d9143a39
RCTDeprecation: c6b36da89aa26090c8684d29c2868dcca2cd4554
RCTRequired: 1413a0844770d00fa1f1bb2da4680adfa8698065
Expand Down Expand Up @@ -2006,6 +1994,6 @@ SPEC CHECKSUMS:
ReactNativeDependencies: bf28df18cc29efa26b3f96b9c22d8b846047563f
Yoga: 9a5a710cf47e32646c6d4689c74ce4c17f13ccdb

PODFILE CHECKSUM: ae3867be4571c77b18342d9a187b0e20a026bc8d
PODFILE CHECKSUM: 1717ce2315e8cab64ebdcc82840b606dd7d6e7bc

COCOAPODS: 1.16.2
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@hotcodepush/react-native-code-push": "https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@2143c58e5a5882df2bd2738f76f0fe2306180b28",
"@hotcodepush/react-native-code-push": "https://pkg.pr.new/hotcodepush-team/react-native-code-push/@hotcodepush/react-native-code-push@56112dd6c11c88b320bf7ca390296e0862f3b27c",
"react": "19.1.1",
"react-native": "0.82.1"
},
Expand All @@ -28,7 +28,7 @@
"@react-native/metro-config": "0.82.1",
"@react-native/typescript-config": "0.82.1",
"@types/react": "19.1.17",
"hotcodepush": "https://pkg.pr.new/hotcodepush-team/cli/hotcodepush@7cbdabe40b97a5c42886ce7a1d1e1743379d25d5",
"hotcodepush": "https://pkg.pr.new/hotcodepush-team/cli/hotcodepush@4eba9a15547714910e489b7a273c787c57862151",
"prettier": "3.9.8",
"typescript": "5.9.3"
},
Expand Down
Loading