refactor: remove legacy PTOPlanMemory pass and --plan-memory-impl option - #1476
Draft
KurrinQu wants to merge 1 commit into
Draft
refactor: remove legacy PTOPlanMemory pass and --plan-memory-impl option#1476KurrinQu wants to merge 1 commit into
KurrinQu wants to merge 1 commit into
Conversation
KurrinQu
force-pushed
the
codecheck-b1-planmemory
branch
from
September 7, 2026 09:42
353ba78 to
a64df92
Compare
The legacy vector-only planner (PTOPlanMemory.cpp) is superseded by PTOPlanMemoryModern, which plans every local address space. Delete the legacy pass and its CLI switch so modern is the only implementation: - drop PTOPlanMemory.cpp/.h and their CMake entry - remove createPlanMemoryPass; point the PlanMemory tablegen def at createPlanMemoryModernPass and anchor GEN_PASS_DEF_PLANMEMORY in PTOPlanMemoryModern.cpp so 'pto-plan-memory' stays registered for pto-test-opt and textual pipelines - delete --plan-memory-impl from ptoas; --plan-memory-order-by-size keeps its default of false so the default pipeline is byte-identical to the previous legacy default path (largest-first ordering stays opt-in; TileLib ST found correctness issues with it on tscatter_mask_col) - update lit tests: drop --plan-memory-impl=modern, remove legacy-only tests, and refresh CHECK expectations (sync emission, address reuse, in-place tile planning) for the modern planner's output Codecheck remediation batch 1: PTOPlanMemory.cpp is obsolete. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy vector-only planner (PTOPlanMemory.cpp) is superseded by PTOPlanMemoryModern, which plans every local address space. Delete the legacy pass and its CLI switch so modern is the only implementation:
pto-plan-memorystays registered for pto-test-opt and textual pipelinesCodecheck remediation batch 1: PTOPlanMemory.cpp is obsolete.