Skip to content

refactor: remove legacy PTOPlanMemory pass and --plan-memory-impl option #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KurrinQu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor: remove legacy PTOPlanMemory pass and --plan-memory-impl option #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions include/PTO/Transforms/Passes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ std::unique_ptr<Pass> createConvertToPTOOpPass();
std::unique_ptr<Pass> createInferPTOMemScopePass();

std::unique_ptr<Pass>
createPlanMemoryPass(const PlanMemoryOptions &options = {});
std::unique_ptr<Pass>
createPlanMemoryModernPass(const PlanMemoryOptions &options);
createPlanMemoryModernPass(const PlanMemoryOptions &options = {});
std::unique_ptr<Pass> createPTORemoveRedundantBarrierPass();
std::unique_ptr<Pass> createPTOValidateIntToPtrUsesPass();
std::unique_ptr<Pass> createPTORematerializeFixpipeVectorQuantPass();
Expand Down
2 changes: 1 addition & 1 deletion include/PTO/Transforms/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def PTOMaterializeImplicitTmp

def PlanMemory : Pass<"pto-plan-memory", "ModuleOp"> {
let summary = "Plan memory for PTO Ops";
let constructor = "mlir::pto::createPlanMemoryPass()";
let constructor = "mlir::pto::createPlanMemoryModernPass()";

let options = [
Option<"memMode", "mem-mode", "std::string", "\"local\"",
Expand Down
1 change: 0 additions & 1 deletion lib/PTO/Transforms/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ add_mlir_dialect_library(PTOTransforms
Utils.cpp
OptMemPlanForPipeline.cpp
InferPTOMemScope.cpp
PTOPlanMemory.cpp
PTOPlanMemoryModern.cpp
PTORemoveRedundantBarrier.cpp
InferPTOLayout.cpp
Expand Down
Loading
Loading