Publish Location code under PCIeDevice schema (#1083)

[souvik1914581]

The commit publishes Location code under PCIeDevice schema.

Validator was executed and no new error was found.

Test:
curl -k -H "X-Auth-Token: $bmc_token" -X GET "https://${BMC_IP}/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard_pcieslot0_pcie_card0" {
"@odata.id": "/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard_pcieslot0_pcie_card0",
"@odata.type": "#PCIeDevice.v1_9_0.PCIeDevice",
"Id": "chassis_motherboard_pcieslot0_pcie_card0",
"Oem": {
"IBM": {
"@odata.type": "#IBMPCIeDevice.v1_0_0.IBM",
"LinkReset": false
}
},
"PCIeFunctions": {
"@odata.id": "/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard_pcieslot0_pcie_card0/PCIeFunctions"
},
"PCIeInterface": {
"LanesInUse": null
},
"Slot": {
"Location": {
"PartLocation": {
"ServiceLabel": "U78DA.ND0.WZS003T-P0-C0"
}
},
"SlotType": "FullLength"
},
"Status": {
"Health": "OK",
"State": "Enabled"
}
}

Change-Id: Iba1b98734fdfee43c2995f6c9f1f2660e196814a

[souvik1914581]

Original commit : 8e7bf1f

[baemyung]

PrettyName and Location are different.

So, please make separate PRs;

• one PR would be to do PrettyName for pcie.hpp (in addition to util: Add pretty name for resources (#918) #1201). - fyi: @deepakala-k
• Another PR for Location code.

[souvik1914581]

PrettyName and Location are different.
So, please make separate PRs;

one PR would be to do PrettyName for pcie.hpp (in addition to #1201). - fyi: @deepakala-k
Another PR for Location code.

@baemyung Can you please tell me why we need to put PrettyName and Location code into separate PRs? If we split the original commit up into two PRs (two commits), we would have to track two commits for any future rebase.

[baemyung]

PrettyName and Location are different.
So, please make separate PRs;
one PR would be to do PrettyName for pcie.hpp (in addition to #1201). - fyi: @deepakala-k
Another PR for Location code.

@baemyung Can you please tell me why we need to put PrettyName and Location code into separate PRs? If we split the original commit up into two PRs (two commits), we would have to track two commits for any future rebase.

They are not related.
It is better to make the different one in separate commits.

In fact, PrettyName part is a bugfix (e.g. missing piece) of PR #1201. So, this part is better to be separate.
(Consider the future rebase situation.
Those commits/PRs [#1201 & bugfix] would be combined into one commit , not with LocationCode part)

[baemyung]

Looks good to me

[souvik1914581]

Hi, requesting more reviews on this PR.

[jeaaustx]

Looks good to me.
nit: If you add three backticks on a line before and on a line after the curl commands and their output in the commit message and in the PR message it will format nicer.